Core: Merge channels into a single package#23032
Merged
Conversation
5 tasks
tmeasday
reviewed
Jun 12, 2023
Member
There was a problem hiding this comment.
Seems like a good step forward but I still don't think createPostMessageChannel() should end up creating both a PM and WS transport, that's just confusing.
My advice would be to have two files, postmessageTransport.ts and websocketTransport.ts that are responsible for the transports, and are "dumb". Then a second file createBrowserChannel or similar that uses the two transports and is used by the builders.
ndelangen
changed the title
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎ |
42 tasks
shilman
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telescoped off: #22940
@storybook/channels./code/deprecated, added shims to the old content that's moved.createPostMessageChannelfrom@storybook/channelscreateBrowserChannelfunctioncreateBrowserChannelCustom builders will need this change applied as well, or their browser won't listen to the serverChannel.