Core: Fix core-common to use node-fetch#23077
Merged
Conversation
15 tasks
Merged
9 tasks
shilman
pushed a commit
that referenced
this pull request
Jun 17, 2023
…mmon Bug: Make core-common use node-fetch (cherry picked from commit a4c2383)
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
I don't know how this has gone unnoticed.
core-common is a node package, but it seems to use
fetchwithout any place where it's imported; meaning it's from a global. Node 16 does not ship with fetch build-in.How to test
Ran into this here:
https://github.com/chromaui/addon-visual-tests
It's using auto-refs, that's likely how this code-path gets executed?
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]