CLI: Prebundle boxen to resolve a ESM/CJS incompatibility#23080
Merged
Conversation
shilman
approved these changes
Jun 15, 2023
This was referenced Jun 15, 2023
Merged
shilman
added a commit
that referenced
this pull request
Jun 17, 2023
CLI: Prebundle boxen to resolve a ESM/CJS incompatibility (cherry picked from commit 56b77e4)
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Users of yarn1 + storybook are running into an issue:
see: https://github.com/chromaui/addon-visual-tests/actions/runs/5275056906/jobs/9540144634?pr=8
@tmeasday investigated this and concluded it's related to:
isaacs/jackspeak#5 (comment)
https://github.com/isaacs/jackspeak/blame/main/package.json#L70
How to test
I think we'll have to do a quick alpha release to get this tested in the place where we know it happens.
I think trying to reproduce this in the monorepo will be extremely tedious and fragile, considering it only seems to happen with yarn1.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]