Next.js: Add experimental SWC support#24852
Merged
valentinpalkovic merged 20 commits intonextfrom Nov 20, 2023
Merged
Conversation
valentinpalkovic
added
feature request
nextjs
ci:daily
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
valentinpalkovic
force-pushed
the
valentin/add-swc-support-for-nextjs
branch
2 times, most recently
from
554ad41 to
ed993be
Compare
valentinpalkovic
requested review from
JReinhold,
jonniebigodes,
kasperpeulen,
kylegach,
ndelangen and
yannbf
as code owners
jonniebigodes
approved these changes
Nov 15, 2023
Contributor
jonniebigodes
left a comment
jonniebigodes
left a comment
There was a problem hiding this comment.
@valentinpalkovic thanks for taking the time to put together this pull request and include the required changes to the documentation. Appreciate it 🙏 ! Only one small thing for you to look into and this should be good to go from my end. Approving this to unblock you.
valentinpalkovic
force-pushed
the
valentin/add-swc-support-for-nextjs
branch
3 times, most recently
from
43c7112 to
bcc8e7e
Compare
valentinpalkovic
force-pushed
the
valentin/add-swc-support-for-nextjs
branch
from
bcc8e7e to
5021bf4
Compare
…k5-projects Next.js: Enable SWC for new Webpack5-based projects
yannbf
reviewed
Nov 20, 2023
| import path from 'path'; | ||
| import type { RuleSetRule } from 'webpack'; | ||
| import semver from 'semver'; | ||
| import { NextjsSWCNotSupportedError } from 'lib/core-events/src/errors/server-errors'; |
Member
There was a problem hiding this comment.
Suggested change
| import { NextjsSWCNotSupportedError } from 'lib/core-events/src/errors/server-errors'; | |
| import { NextjsSWCNotSupportedError } from '@storybook/core-events/server-errors'; |
yannbf
approved these changes
Nov 20, 2023
36 tasks
|
@valentinpalkovic Seems like tracing is removed from original next-swc-loader due to https://github.com/vercel/next.js/pull/65101/files#diff-780a2d4ec404eae0c998ffc7161746a8d26476c1474e0956c1231176ec5fa397 Is it possible to remove patched version of loader? |
Contributor
Author
|
@r34son Good catch! Would you like to open a PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24827
What I did
Added experimental SWC mode for Next.js >= 14
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Next.js 12 sandbox
-> Setting
framework.options.builder.useSWC: trueshouldn't have any effect. Instead the user should get a warning in the console, that SWC mode is only supported in Next.js v14 and above. It would be beneficial also to test Next.js 13, since we currently don't have a Next.js 13 sandbox in place. Just check out one of the Next.js sandboxes and change thenextdependency to the latest v13. The behaviour should be the same as for Next.js v12. SWC is not supported here. Storybook should work as expected in Babel mode.Other Next.js sandboxes
-> Set
framework.options.builder.useSWC: trueand test whether all Next.js Stories are working as expected. Personally, I have tested the local font option already.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>