Core: Make warnOnIncompatibleAddons fault-tolerant

[taozhou-glean]

Closes #23846

more context: #24663 (review)

What I did

catch error from warnOnIncompatibleAddons so we don't fail the build just because of that.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

checked with local repo that has incompatible addons

Documentation

not sure if it should be documented anywhere, seems no for warnOnLegacyHierarchySeparator, so keep it in code only for now.

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[ndelangen]

Seems all-right to me, WDYT @yannbf ?

[yannbf]

Looks great! Thanks for working this through!

[taozhou-glean]

any one know why the create-sandboxes failed ? from the log it says:

An error occurred while installing dependencies:

seems not related to this change...

[yannbf]

any one know why the create-sandboxes failed ? from the log it says:

An error occurred while installing dependencies:

seems not related to this change...

Hey there! There was an issue in CI unrelated to your code changes. I'll get this over the finish line!