Dependencies: Remove qs from @storybook/manager-api & @storybook/channels#26285
Merged
ndelangen merged 4 commits intostorybookjs:nextfrom Mar 7, 2024
Merged
Dependencies: Remove qs from @storybook/manager-api & @storybook/channels#26285ndelangen merged 4 commits intostorybookjs:nextfrom
qs from @storybook/manager-api & @storybook/channels#26285ndelangen merged 4 commits intostorybookjs:nextfrom
Conversation
This removes the `qs` dependency from the `manager-api` and `channels` packages, instead using `URLSearchParams` (native functionality).
qs from @storybook/manager-api & @storybook/channels
ndelangen
approved these changes
Mar 6, 2024
Member
|
@43081j This is great! Thank you for this! I invited you to become a member of the org. I'd be wonderful to get more wins like this 🎉 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e467a0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Contributor
Author
|
thanks for the quick review 🙏 i want to get around to the other & of course thank you for the invite to the org 🥳 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
qsdependency from themanager-apiandchannelspackages, instead usingURLSearchParams(native functionality).Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
N/A - should be covered enough in automated tests