Docs: Fix providerImportSource extension

[bashmish]

What I did

Added extension to the path which is needed in my builder
More info: modernweb-dev/web#2703

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

N/A

Manual testing

I tested in my repo by manually adding an extension.

Documentation

N/A

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[bashmish]

This exact line is causing a bug for me.
I was wondering why do you even need to override providerImportSource in this @storybook/addon-essentials preset? I mean wouldn't providerImportSource be covered for webpack and vite builder by 2 other files? Maybe instead of fixing it by providing the extension it's better to remove this entire override in this file? I have a setup similar to vite where this is already provided by the builder, so not sure why addon (especially the essentials addon) is overriding this.

[yannbf]

@ndelangen could you provide the context here? Thanks!

[ndelangen]

Uhm... don't have the context why it's needed, though I think @JReinhold probably does.

[JReinhold]

I agree that this doesn't look necessary to me. You can try removing it and see if CI still works.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0255264. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build -c production --parallel=3

---

Sent with 💌 from NxCloud.

[bashmish]

@ndelangen thanks for looking into this!
can you backport this to 7.x.x? I can make a PR

[shilman]

Hi @bashmish! Thanks so much for fixing this. We have lots of PRs and our workflow is set up to release A.B.C and A.(B+1).0-$prerelease.D in a streamlined way. So we could conceivably patch this back to 8.0.x but not to 7.0.x without invoking a special case. We typically only do this for severe bugs or security issues. My preference would be to merge this (once it's ready) and release it in 8.1.0-alpha.x and then release it in 8.1.0 in a week or so unless there are important reasons to do otherwise. Please let me know what you think! cc @ndelangen

[bashmish]

@shilman thanks for clear explanation, too bad, but fine by me, I implemented a workaround on my side and will keep it for 7.x.x then.

Given the answer in #26868 (comment), I'd like to try fixing this as discussed in that thread, because it seems more future proof to me for custom builders. So i'm going to update this PR.

UPDATE: on a second thought, let's keep this PR as is and release it, it's a good fix on its own. Removing the other code might take a while for everything to go through, so it's best to keep it in a separate PR for later.