Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6f1110f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This was referenced Jun 12, 2024
Merged
Merged
shilman
added a commit
that referenced
this pull request
Jun 13, 2024
…p-install CLI: Fix `init --skip-install` (cherry picked from commit 3385570)
github-actions
bot
added
the
patch:done
valentinpalkovic
added
needs qa
8 tasks
ndelangen
removed
the
patch:yes
valentinpalkovic
added
needs qa
8 tasks
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27096
What I did
We cannot run
storybook devas part of install if we do not actually install the packages. The bug that we were trying to do this and it was crashing before Storybook had added the packages topackage.json.Checklist for Contributors
Testing
Manual testing
In a fresh project (I've done this):
path/to/code/lib/cli/bin/index.js init --skip-installnode_modulespnpm install🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>