Skip to content

Addon Onboarding: Add icons for dev/test/doc to the splash screen#28389

Merged
ghengeveld merged 6 commits intonextfrom
add-onboarding-icons
Jul 1, 2024
Merged

Addon Onboarding: Add icons for dev/test/doc to the splash screen#28389
ghengeveld merged 6 commits intonextfrom
add-onboarding-icons

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 28, 2024

What I did

Added icons for Development, Testing and Documentation to the onboarding splash screen. These were overlooked in the initial implementation.

Screenshot 2024-06-28 at 17 18 11

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@nx-cloud
Copy link

nx-cloud bot commented Jun 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e36432f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld added feature request ci:merged Run the CI jobs that normally run when merged. labels Jun 29, 2024
@ghengeveld ghengeveld requested a review from cdedreuille June 29, 2024 17:46
@ghengeveld ghengeveld changed the title Add icons for dev/test/doc to the onboarding splash screen Addon Onboarding: Add icons for dev/test/doc to the onboarding splash screen Jun 29, 2024
@ghengeveld ghengeveld changed the title Addon Onboarding: Add icons for dev/test/doc to the onboarding splash screen Addon Onboarding: Add icons for dev/test/doc to the splash screen Jun 29, 2024
@ghengeveld ghengeveld merged commit 453f933 into next Jul 1, 2024
@ghengeveld ghengeveld deleted the add-onboarding-icons branch July 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:merged Run the CI jobs that normally run when merged. feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants