UI: Fix collapse/expand all functionality#28582
Merged
ghengeveld merged 3 commits intostorybookjs:nextfrom Aug 1, 2024
Merged
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
- Updated
collapsemenu item in/code/core/src/manager/container/Menu.tsxto emitSTORIES_COLLAPSE_ALLevent - Removed deprecated
api.collapseAllmethod call - Fixed error thrown when clicking 'Collapse All' due to missing method
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
shilman
reviewed
Jul 15, 2024
Member
shilman
left a comment
There was a problem hiding this comment.
There's also a dangling reference to collapseAll in shortcuts.ts. Can we fix that too?
ghengeveld
approved these changes
Aug 1, 2024
Member
ghengeveld
left a comment
There was a problem hiding this comment.
Looks good, just a minor comment to handle expandAll as well.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4b319d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
14 tasks
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28457
Fix: Update Menu "Collapse All" option to emit STORIES_COLLAPSE_ALL
Issue: Clicking on "Collapse All" throws an error
api.collapseAll is not a functionSolution: Updated the
collapsefrom the Menus.tsx component so it can emit the new events instead of calling the old methods.Testing
References:
Related issue: #28457
Related PR: #25486