Webpack: Fix sourceMap generation in csf-tools#28585
Merged
valentinpalkovic merged 1 commit intonextfrom Jul 12, 2024
Merged
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit af48f0d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Contributor
There was a problem hiding this comment.
PR Summary
- Updated import statement for
@babel/generatorin/code/core/src/csf-tools/CsfFile.ts - Modified
formatCsffunction to acceptGeneratorOptionswithinputSourceMapin/code/core/src/csf-tools/CsfFile.ts - Added
sourceFileNameparameter toformatCsffunction call in/code/lib/csf-plugin/src/webpack-loader.ts - Improved source map generation for Webpack in
csf-tools - Addressed issue #28576
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ndelangen
approved these changes
Jul 12, 2024
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
…or-webpack Webpack: Fix sourceMap generation in csf-tools (cherry picked from commit 239ce53)
This was referenced Jul 12, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
…or-webpack Webpack: Fix sourceMap generation in csf-tools (cherry picked from commit 239ce53)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
…or-webpack Webpack: Fix sourceMap generation in csf-tools (cherry picked from commit 239ce53)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
…or-webpack Webpack: Fix sourceMap generation in csf-tools (cherry picked from commit 239ce53)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28576
What I did
I have added
babel.generateenough information to produce a source map file to correctly define thesourcesproperty instead of setting it to[undefined]Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template react-vite/default-ts@storybook/addon-storysourceaddonDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28585-sha-af48f0d6. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28585-sha-af48f0d6 sandboxor in an existing project withnpx storybook@0.0.0-pr-28585-sha-af48f0d6 upgrade.More information
0.0.0-pr-28585-sha-af48f0d6valentin/fix-source-maps-for-webpackaf48f0d61720820233)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28585