Vue: Add missing prop controls when using vue-component-meta docgen plugin#28760
Vue: Add missing prop controls when using vue-component-meta docgen plugin#28760kasperpeulen merged 4 commits intonextfrom
vue-component-meta docgen plugin#28760Conversation
There was a problem hiding this comment.
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 01d1ef2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
vue-component-meta docgen pluginvue-component-meta docgen plugin
|
@kasperpeulen would you mind taking a look at this once you have the time? |
7232754 to
a923538
Compare
|
@yannbf @kasperpeulen Hey, is there any estimate when we can release this bug fix? :) |
|
@storybookjs/core Hey guys :) Does someone have time to review and release this bug fix? This is currently a blocker for projects wanting to update to the new Vue version 3.5 Thanks! |
JReinhold
left a comment
There was a problem hiding this comment.
LGTM, thanks for the code comments.
@kasperpeulen should look too though.
|
@larsrickert Sorry, totally missed this because of holidays! I have enabled auto-merge, so once the lint job is fixed, it should automatically merge. This will get into the 8.3 release. |
@kasperpeulen I hope you had a good vacation! |
|
Thanks, and force merged now! |
What I did
Follow up fix for #28589 and #28674 which caused missing prop controls for enum types (e.g. booleans or
"small" | "medium"etc in the current8.3.0-alpha.3version.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template vue3-vite/default-ts🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This pull request addresses missing prop controls for enum types in Vue components when using the
vue-component-metadocgen plugin.code/frameworks/vue3-vite/src/plugins/vue-component-meta.tsto retain nested schemas for enum entries, ensuring prop controls are displayed correctly.