Vitest plugin: Fix renamed export stories#29250
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d23542f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
yannbf
approved these changes
Oct 1, 2024
Member
There was a problem hiding this comment.
Thanks! Changes look good, but I found a bug in CsfFile (which could be done in a separate PR) where the story names are not handled in reexported consts like so:
const B = () => {}
B.storyName = 'Custom name B'
const C = {
name: 'Custom name C'
}
// story name is still B and D, should be "Custom name ..." for each story
export { B, C as D }
storybook-bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…ed-exports Vitest plugin: Fix renamed export stories (cherry picked from commit ed00bc5)
This was referenced Oct 2, 2024
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
…ed-exports Vitest plugin: Fix renamed export stories (cherry picked from commit ed00bc5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29244
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
In a sandbox, create a story that uses a renamed export and verify that the Vitest test succeeds. (I did not test!)
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR adds support for renamed exports in the Storybook Vitest plugin, addressing issue #29244.
localNameproperty toStaticStoryinterface inCsfFile.tsto store original variable namestransformer.tsto uselocalNamewhen generating test statements for renamed exportsCsfFile.test.tsto include tests for the newlocalNamepropertytransformer.test.tsto verify handling of renamed exported stories