RNW-Vite: Add tsconfig path aliases support#29953
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
shilman
force-pushed
the
shilman/rnw-add-typescript-paths
branch
from
f973344 to
bbfabab
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bbfabab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 102 | 105 | 🚨 +3 🚨 |
| Self size | 41 KB | 41 KB | 🚨 +389 B 🚨 |
| Dependency size | 17.86 MB | 18.01 MB | 🚨 +154 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Member
|
Tested this, works 👍 |
dannyhw
approved these changes
Dec 8, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
New Expo projects use tsconfig path aliases by default, so support it out of the box.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run the expo sandbox and create a story for a component that uses tsconfig path imports, e.g.
import Component from '@/components/Component'.🦋 Canary release
This pull request has been released as version
0.0.0-pr-29953-sha-bbfabab3. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-29953-sha-bbfabab3 sandboxor in an existing project withnpx storybook@0.0.0-pr-29953-sha-bbfabab3 upgrade.More information
0.0.0-pr-29953-sha-bbfabab3shilman/rnw-add-typescript-pathsbbfabab31733671523)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=29953Greptile Summary
Adds TypeScript path alias support for React Native Web Vite projects, enabling default path aliases in new Expo projects through the integration of vite-tsconfig-paths plugin.
vite-tsconfig-pathsdependency (^5.1.4) incode/frameworks/react-native-web-vite/package.jsontsconfigPaths()plugin incode/frameworks/react-native-web-vite/src/vite-plugin.tsandpreset.ts