Addon Test: Clear coverage data when starting or watching#30072
Merged
ghengeveld merged 19 commits intonextfrom Dec 17, 2024
Merged
Addon Test: Clear coverage data when starting or watching#30072ghengeveld merged 19 commits intonextfrom
ghengeveld merged 19 commits intonextfrom
Conversation
…version range handling
Due to the following issue nrwl/nx#28806, which we encounter in the GitHub Window Unit Test Job regularly, we have to opt-in to NX's legacy cache mechanism. That will use the file system instead of a file DB for caching.
8 tasks
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fc703e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Contributor
There was a problem hiding this comment.
102 file(s) reviewed, 13 comment(s)
Edit PR Review Bot Settings | Greptile
code/lib/cli-storybook/src/automigrate/fixes/addon-a11y-addon-test.test.ts
Show resolved
Hide resolved
code/lib/cli-storybook/src/automigrate/fixes/addon-a11y-addon-test.test.ts
Show resolved
Hide resolved
ndelangen
reviewed
Dec 16, 2024
JReinhold
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Copilot AI
added a commit
to yannbf/storybook
that referenced
this pull request
Mar 6, 2026
…ort when content is tall Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
Copilot AI
added a commit
to yannbf/storybook
that referenced
this pull request
Mar 6, 2026
…ort + add E2E test + update skill docs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: yannbf <1671563+yannbf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #30062
What I did
This clears the coverage data when starting a new test run or enabling watch mode, in order to prevent stale coverage data from lingering.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Based on the provided files and changes, I'll create a concise summary of this PR:
This PR enhances the test addon to clear coverage data when starting new test runs or enabling watch mode, preventing stale coverage information from persisting between test sessions.
code/addons/test/src/manager.tsxto properly clear coverage data on test start/watchdocs/writing-tests/test-coverage.mdxwith Vitest 3.0.0 referencestest-storybooks/portable-stories-kitchen-sink/react/.storybook/main.tsscripts/task.tswith helpful task name suggestionsuseLegacyCache: "true"tocode/nx.jsonfor build system compatibility