Core: Float context menu button on top of story titles in sidebar#30080
Merged
ghengeveld merged 5 commits intonextfrom Dec 18, 2024
Merged
Core: Float context menu button on top of story titles in sidebar#30080ghengeveld merged 5 commits intonextfrom
ghengeveld merged 5 commits intonextfrom
Conversation
…nt backgrounds to make it look good
Contributor
There was a problem hiding this comment.
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit eed0b8b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
JReinhold
approved these changes
Dec 17, 2024
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
Member
Author
|
As discussed with MA, I've updated the status icons to never overlay the text but instead claim space for themselves. Only the context menu button should overlay the text because it's visible only on hover. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29651
What I did
Renders story context menu buttons and status icons on top of the story/component/folder title to prevent the sidebar from reflowing on hover. Transparent backgrounds have been replaced with opaque colors to prevent the text from showing through. Buttons have a slight outer glow to make it look like a gradient.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Based on the provided information, I'll create a concise summary of the PR changes focused on improving the sidebar's context menu and status icon rendering:
Improves sidebar rendering by making context menu buttons and status icons float on top of story titles using absolute positioning, preventing layout reflow issues when hovering.
Tree.tsxto use absolute positioning for menu buttons and handle overflow properlyStatusButton.tsxto include opaque backgrounds and box shadows instead of transparent backgrounds