Build: Downgrade to esbuild 0.24.0#30116
Conversation
yannbf
added
dependencies
maintenance
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| "danger": "^12.3.3", | ||
| "es-toolkit": "^1.22.0", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0", |
There was a problem hiding this comment.
style: Consider keeping version range for dependencies to avoid potential conflicts with other packages requiring different esbuild versions. Pinning in resolutions should be sufficient.
| "better-opn": "^3.0.2", | ||
| "browser-assert": "^1.2.1", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0", | ||
| "esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0", |
There was a problem hiding this comment.
style: Pinning esbuild to exactly 0.24.0 instead of allowing newer patch versions could prevent getting important bug fixes. Consider using ^0.24.0 instead.
| }, | ||
| "resolutions": { | ||
| "esbuild": "^0.24.0", | ||
| "esbuild": "0.24.0", |
There was a problem hiding this comment.
style: Pinning esbuild to exact version 0.24.0 may miss critical security patches. Consider using ~0.24.0 to allow patch updates
|
View your CI Pipeline Execution ↗ for commit a8a20ff.
☁️ Nx Cloud last updated this comment at |
yannbf
removed
the
patch:yes
2 participants
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Downgraded esbuild to version 0.24.0 across multiple package.json files to address CI issues while maintaining backward compatibility with existing build processes.
code/package.jsonresolutions and dependenciescode/core/package.jsonto pin esbuild to 0.24.0 while preserving compatibility with versions 0.18.0-0.23.0scripts/package.jsonto use exact version 0.24.0 instead of caret range