Addon Test: Replace interaction test -> component test#30333
Merged
Conversation
kylegach
added
cli
patch:yes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
21 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| // More on interaction testing: https://storybook.js.org/docs/writing-tests/interaction-testing | ||
| // More on component testing: https://storybook.js.org/docs/writing-tests/component-testing | ||
| export const LoggedIn: Story = { | ||
| play: async ({ canvasElement }: any) => { |
Contributor
There was a problem hiding this comment.
style: any type used in TypeScript - consider using a more specific type for canvasElement
| // More on interaction testing: https://storybook.js.org/docs/writing-tests/interaction-testing | ||
| // More on component testing: https://storybook.js.org/docs/writing-tests/component-testing | ||
| export const LoggedIn: Story = { | ||
| play: async ({ canvasElement }: any) => { |
Contributor
There was a problem hiding this comment.
style: Type 'any' used for canvasElement parameter. Consider using a more specific type for better type safety.
|
View your CI Pipeline Execution ↗ for commit 80c12f5.
☁️ Nx Cloud last updated this comment at |
shilman
approved these changes
Jan 22, 2025
shilman
changed the title
interaction test -> component testinteraction test -> component test
This was referenced Jan 22, 2025
Merged
shilman
added a commit
that referenced
this pull request
Jan 23, 2025
Addon Test: Replace `interaction test` -> `component test` (cherry picked from commit edbaea1)
github-actions
bot
added
the
patch:done
ndelangen
removed
the
patch:yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
In the Test addon panel's empty state and all CLI template stories, replace "interaction test" with "component test"
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-tsDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates terminology from 'interaction testing' to 'component testing' across multiple template files and the Test addon panel's empty state, ensuring consistent documentation and UI messaging.
code/addons/test/src/components/EmptyState.tsxfrom 'Interaction testing' to 'Component testing'