Builder-Vite: Fix runtime and iframe 404 on first load#30567
Merged
valentinpalkovic merged 11 commits intonextfrom Feb 19, 2025
Merged
Builder-Vite: Fix runtime and iframe 404 on first load#30567valentinpalkovic merged 11 commits intonextfrom
valentinpalkovic merged 11 commits intonextfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit b7126ab.
☁️ Nx Cloud last updated this comment at |
Contributor
|
Failed to publish canary version of this pull request, triggered by @valentinpalkovic. See the failed workflow run at: https://github.com/storybookjs/storybook/actions/runs/13400680087 |
valentinpalkovic
force-pushed
the
valentin/fix-runtime-iframe-error-on-first-load
branch
from
561edf3 to
f39169d
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 52 | 52 | 0 |
| Self size | 19.26 MB | 19.25 MB | 🎉 -1 KB 🎉 |
| Dependency size | 14.26 MB | 14.19 MB | 🎉 -62 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 53 | 53 | 0 |
| Self size | 23 KB | 23 KB | 0 B |
| Dependency size | 33.51 MB | 33.45 MB | 🎉 -63 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 54 | 54 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 33.54 MB | 33.47 MB | 🎉 -63 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 359 | 359 | 0 |
| Self size | 279 KB | 279 KB | 0 B |
| Dependency size | 84.00 MB | 83.94 MB | 🎉 -63 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 275 | 275 | 0 |
| Self size | 612 KB | 612 KB | 🎉 -6 B 🎉 |
| Dependency size | 65.58 MB | 65.52 MB | 🎉 -63 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
JReinhold
approved these changes
Feb 19, 2025
valentinpalkovic
changed the title
valentinpalkovic
deleted the
valentin/fix-runtime-iframe-error-on-first-load
branch
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30378
What I did
optimizeDeps.includeconfiguration to avoid issues when Storybook starts up the first time.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-30567-sha-f5452a43. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-30567-sha-f5452a43 sandboxor in an existing project withnpx storybook@0.0.0-pr-30567-sha-f5452a43 upgrade.More information
0.0.0-pr-30567-sha-f5452a43valentin/fix-runtime-iframe-error-on-first-loadf5452a431739962378)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=30567Greptile Summary
Added new dependencies to Vite's optimizeDeps configuration to prevent runtime and iframe 404 errors that occur on first load of Storybook.
@storybook/addon-interactions/previewtoINCLUDE_CANDIDATESincode/builders/builder-vite/src/optimizeDeps.tsreact/jsx-dev-runtimetoINCLUDE_CANDIDATESfor proper React development runtime support