Skip to content

Commit 295f503

Browse files
committed
Review comment changes
1 parent f580037 commit 295f503

File tree

27 files changed

+129
-4387
lines changed

27 files changed

+129
-4387
lines changed

.gitignore

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,6 @@ temp/
2828
test/sandbox
2929
test/.pkgcache/
3030
.pkgcache/
31-
intl/MSG.json
32-
intl/de/*
33-
intl/es/*
34-
intl/fr/*
35-
intl/it/*
36-
intl/ja/*
37-
intl/ko/*
38-
intl/pt/*
39-
intl/ru/*
40-
intl/zh-Hans/*
41-
intl/zh-Hant/*
42-
intl/zz/*
31+
!intl/
32+
intl/*
33+
!intl/en/

app/index.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,22 @@ module.exports = yeoman.Base.extend({
3535

3636
this.option('skip-install', {
3737
desc: g.f('Do not install npm dependencies.'),
38-
type: Boolean
38+
type: Boolean,
3939
});
4040

4141
this.option('skip-next-steps', {
4242
desc: g.f('Do not print "next steps" info'),
43-
type: Boolean
43+
type: Boolean,
4444
});
4545

4646
this.option('explorer', {
4747
desc: g.f('Add Loopback Explorer to the project (true by default)'),
48-
type: Boolean
48+
type: Boolean,
4949
});
5050
},
5151

5252
greet: function() {
53-
g.log(yosay(g.f('Let\'s create a LoopBack application!')));
53+
this.log(yosay(g.f('Let\'s create a LoopBack application!')));
5454
},
5555

5656
help: function() {
@@ -89,7 +89,7 @@ module.exports = yeoman.Base.extend({
8989
this.templates = list.map(function(t) {
9090
return {
9191
name: g.f('%s (%s)', t.name, t.description),
92-
value: t.name
92+
value: t.name,
9393
};
9494
});
9595

@@ -215,7 +215,7 @@ module.exports = yeoman.Base.extend({
215215
},
216216

217217
generateYoRc: function() {
218-
g.log('Generating .yo-rc.json');
218+
this.log(g.f('Generating {{.yo-rc.json}}'));
219219
this.config.save();
220220
},
221221

@@ -230,27 +230,27 @@ module.exports = yeoman.Base.extend({
230230
this.log();
231231
}
232232

233-
g.log('Next steps:');
233+
this.log(g.f('Next steps:'));
234234
this.log();
235235
if (this.dir && this.dir !== '.') {
236-
g.log(' Change directory to your app');
236+
this.log(g.f(' Change directory to your app'));
237237
this.log(chalk.green(' $ cd ' + this.dir));
238238
this.log();
239239
}
240240
if (cmd === 'apic') {
241-
g.log(' Run API Designer to create, test, and publish your' +
242-
' application');
241+
this.log(g.f(' Run API Designer to create, test, and publish your' +
242+
' application'));
243243
this.log(chalk.green(' $ apic edit'));
244244
this.log();
245245
} else {
246-
g.log(' Create a model in your app');
246+
this.log(g.f(' Create a model in your app'));
247247
this.log(chalk.green(' $ ' + cmd + ' loopback:model'));
248248
this.log();
249-
g.log(
250-
' Compose your API, run, deploy, profile, and monitor it with Arc');
249+
this.log(g.f(
250+
' Compose your API, run, deploy, profile, and monitor it with Arc'));
251251
this.log(chalk.green(' $ slc arc'));
252252
this.log();
253-
g.log(' Run the app');
253+
this.log(g.f(' Run the app'));
254254
this.log(chalk.green(' $ node .'));
255255
this.log();
256256
}

boot-script/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55

66
'use strict';
77

8-
var path = require('path');
98
var SG = require('strong-globalize');
109
var g = SG();
1110

1211
var helpers = require('../lib/helpers');
12+
var path = require('path');
1313
var yeoman = require('yeoman-generator');
1414

1515
var validateRequiredName = helpers.validateRequiredName;
@@ -37,7 +37,7 @@ module.exports = yeoman.Base.extend({
3737

3838
var question = {
3939
name: 'name',
40-
message: g.f('Enter the script name (without `.js`):'),
40+
message: g.f('Enter the script name (without {{`.js`}}):'),
4141
default: this.name,
4242
validate: validateRequiredName,
4343
};
@@ -56,7 +56,7 @@ module.exports = yeoman.Base.extend({
5656
choices: [
5757
{name: g.f('async'), value: 'async'},
5858
{name: g.f('sync'), value: 'sync'}],
59-
default: 'async'
59+
default: 'async',
6060
};
6161

6262
return this.prompt(question).then(function(answer) {

datasource/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
'use strict';
77

8-
var path = require('path');
98
var SG = require('strong-globalize');
109
var g = SG();
1110

@@ -19,6 +18,7 @@ var actions = require('../lib/actions');
1918
var helpers = require('../lib/helpers');
2019
var validateRequiredName = helpers.validateRequiredName;
2120
var objectValidator = helpers.objectValidator;
21+
var path = require('path');
2222
var fs = require('fs');
2323

2424
module.exports = yeoman.Base.extend({
@@ -171,7 +171,7 @@ module.exports = yeoman.Base.extend({
171171
if (!prompts.length && !warnings.length)
172172
return;
173173

174-
g.log('Connector-specific configuration:');
174+
this.log(g.f('Connector-specific configuration:'));
175175
if (!prompts.length) return reportWarnings();
176176

177177
return this.prompt(prompts).then(function(props) {

export-api-def/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = yeoman.Base.extend({
2525
type: String,
2626
alias: 'o',
2727
desc: g.f('Name/Full path to the output file.'),
28-
defaults: ''
28+
defaults: '',
2929
});
3030
},
3131

0 commit comments

Comments
 (0)