From 0d8624b1011c9ba4e025f3c85d49e9b954aec24d Mon Sep 17 00:00:00 2001
From: Niels Pardon <par@zurich.ibm.com>
Date: Wed, 26 Nov 2025 14:01:21 +0100
Subject: [PATCH] fix: add missing serialVersionUIDs

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
---
 build-logic/src/main/resources/substrait-pmd.xml              | 1 +
 .../main/java/io/substrait/function/ParameterizedType.java    | 3 +++
 core/src/main/java/io/substrait/function/TypeExpression.java  | 4 +++-
 core/src/main/java/io/substrait/type/Deserializers.java       | 2 ++
 .../main/java/io/substrait/type/parser/TypeStringParser.java  | 3 +++
 .../java/io/substrait/type/proto/GenericRoundtripTest.java    | 3 +++
 6 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/build-logic/src/main/resources/substrait-pmd.xml b/build-logic/src/main/resources/substrait-pmd.xml
index c115976f8..5282c3a06 100644
--- a/build-logic/src/main/resources/substrait-pmd.xml
+++ b/build-logic/src/main/resources/substrait-pmd.xml
@@ -20,4 +20,5 @@
   <rule ref="category/java/bestpractices.xml/UnusedPrivateField" />
   <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod" />
   <rule ref="category/java/design.xml/AvoidThrowingRawExceptionTypes" />
+  <rule ref="category/java/errorprone.xml/MissingSerialVersionUID" />
 </ruleset>
diff --git a/core/src/main/java/io/substrait/function/ParameterizedType.java b/core/src/main/java/io/substrait/function/ParameterizedType.java
index 1f151c8a7..e514fb975 100644
--- a/core/src/main/java/io/substrait/function/ParameterizedType.java
+++ b/core/src/main/java/io/substrait/function/ParameterizedType.java
@@ -11,6 +11,9 @@
 public interface ParameterizedType extends TypeExpression {
 
   class RequiredParameterizedVisitorException extends RuntimeException {
+
+    private static final long serialVersionUID = 5009974222890249956L;
+
     @Override
     public synchronized Throwable fillInStackTrace() {
       return this;
diff --git a/core/src/main/java/io/substrait/function/TypeExpression.java b/core/src/main/java/io/substrait/function/TypeExpression.java
index 5d6363646..a183c1959 100644
--- a/core/src/main/java/io/substrait/function/TypeExpression.java
+++ b/core/src/main/java/io/substrait/function/TypeExpression.java
@@ -6,7 +6,9 @@
 @Value.Enclosing
 public interface TypeExpression {
 
-  class RequiredTypeExpressionVisitorException extends RuntimeException {}
+  class RequiredTypeExpressionVisitorException extends RuntimeException {
+    private static final long serialVersionUID = 8381558691397737963L;
+  }
 
   <R, E extends Throwable> R accept(final TypeVisitor<R, E> typeVisitor) throws E;
 
diff --git a/core/src/main/java/io/substrait/type/Deserializers.java b/core/src/main/java/io/substrait/type/Deserializers.java
index bc90ecf1e..13936dc07 100644
--- a/core/src/main/java/io/substrait/type/Deserializers.java
+++ b/core/src/main/java/io/substrait/type/Deserializers.java
@@ -30,6 +30,8 @@ public class Deserializers {
 
   public static class ParseDeserializer<T> extends StdDeserializer<T> {
 
+    private static final long serialVersionUID = 2105956703553161270L;
+
     private final BiFunction<String, SubstraitTypeParser.StartContext, T> converter;
 
     public ParseDeserializer(
diff --git a/core/src/main/java/io/substrait/type/parser/TypeStringParser.java b/core/src/main/java/io/substrait/type/parser/TypeStringParser.java
index 8085ea6b8..b8e94793b 100644
--- a/core/src/main/java/io/substrait/type/parser/TypeStringParser.java
+++ b/core/src/main/java/io/substrait/type/parser/TypeStringParser.java
@@ -65,6 +65,9 @@ public void syntaxError(
   }
 
   public static class ParseError extends RuntimeException {
+
+    private static final long serialVersionUID = -6831467523614033666L;
+
     public ParseError(final String message, final Throwable cause) {
       super(message, cause);
     }
diff --git a/core/src/test/java/io/substrait/type/proto/GenericRoundtripTest.java b/core/src/test/java/io/substrait/type/proto/GenericRoundtripTest.java
index dce8490f1..268729c68 100644
--- a/core/src/test/java/io/substrait/type/proto/GenericRoundtripTest.java
+++ b/core/src/test/java/io/substrait/type/proto/GenericRoundtripTest.java
@@ -143,6 +143,9 @@ private static Object valGenerator(Class<?> type) {
 
   // Class used to propagate type generation errors from param generator to test cases
   private static class UnsupportedTypeGenerationException extends Exception {
+
+    private static final long serialVersionUID = -8627552468610061245L;
+
     public UnsupportedTypeGenerationException(String s) {
       super(s);
     }