Skip to content

Commit c929766

Browse files
2JooYeonjoo_yeon.lee
andauthored
fix: /metrics endpoint always reports engine_type="unified" in PD disaggregation mode (sgl-project#18552)
Co-authored-by: joo_yeon.lee <joo_yeon.lee@samsung.com>
1 parent d91ce17 commit c929766

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

python/sglang/srt/entrypoints/grpc_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ async def HealthCheck(
325325
token_ids_logprob=None,
326326
)
327327
# Set disaggregation params if needed
328-
if self.server_args.disaggregation_mode != DisaggregationMode.NULL:
328+
if self.server_args.disaggregation_mode != DisaggregationMode.NULL.value:
329329
health_req.bootstrap_host = FAKE_BOOTSTRAP_HOST
330330
health_req.bootstrap_room = 0
331331
else:
@@ -1087,7 +1087,7 @@ def _execute_grpc_server_warmup(server_args: ServerArgs):
10871087
}
10881088

10891089
# Set disaggregation params if needed
1090-
if server_args.disaggregation_mode != DisaggregationMode.NULL:
1090+
if server_args.disaggregation_mode != DisaggregationMode.NULL.value:
10911091
warmup_request_kwargs["disaggregated_params"] = (
10921092
sglang_scheduler_pb2.DisaggregatedParams(
10931093
bootstrap_host=FAKE_BOOTSTRAP_HOST,

python/sglang/srt/entrypoints/http_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ async def health_generate(request: Request) -> Response:
489489
)
490490
if (
491491
_global_state.tokenizer_manager.server_args.disaggregation_mode
492-
!= DisaggregationMode.NULL
492+
!= DisaggregationMode.NULL.value
493493
):
494494
gri.bootstrap_host = FAKE_BOOTSTRAP_HOST
495495
gri.bootstrap_room = 0

python/sglang/srt/managers/scheduler_metrics_mixin.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,11 @@ def init_metrics(
104104
)
105105

106106
if self.enable_metrics:
107-
if self.server_args.disaggregation_mode == DisaggregationMode.PREFILL:
107+
if self.server_args.disaggregation_mode == DisaggregationMode.PREFILL.value:
108108
engine_type = "prefill"
109-
elif self.server_args.disaggregation_mode == DisaggregationMode.DECODE:
109+
elif (
110+
self.server_args.disaggregation_mode == DisaggregationMode.DECODE.value
111+
):
110112
engine_type = "decode"
111113
else:
112114
engine_type = "unified"

0 commit comments

Comments
 (0)