fix(ext/ai): Invalid tensor length causing Segmentation Fault - #483
Merged
nyannyacha merged 4 commits intoFeb 3, 2025
Conversation
- ERROR: If a blank data `Tensor` is created and then used to feed `Session` it will panic! with "Segmentation Fault: 11" error. So we must prevent it by checking if the `Tensor` size reflects in its `dim shape`
laktek
approved these changes
Feb 2, 2025
Contributor
|
@nyannyacha can you take a look? |
nyannyacha
requested changes
Feb 3, 2025
nyannyacha
approved these changes
Feb 3, 2025
|
🎉 This PR is included in version 1.66.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
nyannyacha
added a commit
to nyannyacha/edge-runtime
that referenced
this pull request
Feb 20, 2025
…se#483) * fix(sb_ai): prevent creation of invalid ort tensors refs - ERROR: If a blank data `Tensor` is created and then used to feed `Session` it will panic! with "Segmentation Fault: 11" error. So we must prevent it by checking if the `Tensor` size reflects in its `dim shape` * fix(ext/ai): add an utility crate * chore: update `Cargo.lock` * stamp: use `v8_do` instead of initialize v8 platform manually --------- Co-authored-by: Nyannyacha <meow@nnc.gg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, CRITICAL
What is the current behavior?
If a
Tensorreceived from JS land havesdata.lengthnot compatible with thedimsthen when feeding theSessiona Segmentation Fault: 11 error will be panic!.How to reproduce it:
The tensors is successfully handled by
rustas wellJsTensor::extract_ort_inputbut error will be panic when feed this values into theSession../scripts/run.sh: line 13: 12963 Segmentation fault: 11 RUST_BACKTRACE=full ./target/debug/edge-runtime "$@" start --main-service ./examples/main --event-worker ./examples/event-managerWhat is the new behavior?
Following the ort api reference: The 'N' of elements 'T' must be equal to the Tensor's 'dims product'.
So we must prevent it by checking if the
Tensorlength reflects in itsdim shape