feat(comments): improve floating comments ui#2195
Merged
caio-pizzol merged 14 commits intomainfrom Feb 26, 2026
Merged
Conversation
…llapse, and truncation
…mat text in bubbles
…utside race condition
…comments by default
caio-pizzol
requested review from
VladaHarbour,
artem-harbour,
harbournick and
palmer-cl
and removed request for
harbournick
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5693a2a737
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…ments Three bugs prevented the "add comment via UI bubble" flow from working on blank documents: 1. commentID vs commentId case mismatch in showAddComment (comments-store.js) 2. Blank documents created without an id, causing fileId/currentDocument.id mismatch in FloatingComments 3. hasInitializedLocations never set for DOCX documents (only wired to PDFViewer), blocking FloatingComments from rendering Also extracts shared comment test helpers (addCommentViaUI, activeCommentDialog) to reduce duplication across behavior tests.
Cover reply pill, thread collapse, faded highlights, and resolve flow. Add getCommentId and addCommentViaUIWithId helpers.
…nt support Restore isTrackedChangeThread guard in syncResolvedCommentsWithDocument to prevent resolved tracked changes from being accidentally reopened. Add PDF fallback in getPendingAnchorTop to use selection bounds when editor positions are unavailable.
4 tasks
Re-assert highlight exists after replyToComment calls (WebKit re-render) and add extra waitForStable + bump dialog timeout for Firefox.
DomPainter: inactive comments now show faded background instead of empty. SuperDoc: CommentDialog moved inside FloatingComments, check that instead.
On Firefox, clicking a presentation-layer highlight doesn't propagate to set activeComment in the Vue store. On WebKit, highlights disappear after replyToComment calls and click events don't trigger setFocus. The new activateCommentDialog helper tries: highlight click → dialog click → store $patch fallback. Also fixes pre-existing edit-comment-text Firefox failure. Skips thread-collapse on WebKit (v-click-outside race).
…te on expand - FloatingComments: only eagerly add comment IDs near the viewport to visibleIds instead of all IDs, preventing a jank frame on documents with 100+ comments during initial load - comments-store: expand deleteComment guard to also clear activeComment when it points to a deleted child reply, not just the parent - CommentDialog: call setFocus() inside expandThread() so clicking "N more replies" both expands and activates the card
caio-pizzol
deleted the
caio/sd-2016-improve-comment-bubble-ux-clean-up-inactive-state-collapse
branch
Contributor
|
🎉 This PR is included in superdoc v1.17.0-next.21 The release is available on GitHub release |
Contributor
|
🎉 This PR is included in superdoc-cli v0.2.0-next.16 The release is available on GitHub release |
This was referenced Feb 27, 2026
harbournick
added a commit
that referenced
this pull request
Feb 28, 2026
This reverts commit e870cfb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.