Skip to content

fix(workflows): point homepage notify at stable orchestrator - #3229

Merged
caio-pizzol merged 1 commit into
mainfrom
fix-notify-homepage-orchestrator
May 11, 2026
Merged

fix(workflows): point homepage notify at stable orchestrator#3229
caio-pizzol merged 1 commit into
mainfrom
fix-notify-homepage-orchestrator

Conversation

@caio-pizzol

Copy link
Copy Markdown
Contributor

Stable superdoc releases now ship via `release-stable.yml` (the orchestrator from #3204/#3221/#3222), so listening to `📦 Release superdoc` on `workflow_run` silently stopped firing for stable releases. The homepage auto-bump would just stop working.

Mirrors the trigger change already in place on `promote-stable-docs.yml`:

  • workflow_run listens to the orchestrator (`📦 Release stable tooling (CLI/SDK/MCP)`).
  • Accept conclusion `failure` too: a tools-chain failure that follows a successful superdoc release should still notify (chain-independent orchestrator semantics).
  • Verify both `superdoc` and `@harbour-enterprises/superdoc` on npm before dispatching; `@semantic-release/git`'s prepare phase pushes the v* tag before publish runs, so a tag-without-publish failure would otherwise notify on an unpublished version.

Flagged by chatgpt-codex-connector in #3228.

Stable superdoc releases now ship via release-stable.yml (named
'📦 Release stable tooling (CLI/SDK/MCP)'), so listening to
'📦 Release superdoc' on workflow_run silently stopped firing for
stable releases. Mirrors the trigger change already in place on
promote-stable-docs.yml.

- Trigger now matches the orchestrator workflow name.
- Accept conclusion: failure too, so a tools-chain failure following a
  successful superdoc release still notifies (chain-independent
  orchestrator semantics).
- Verify both 'superdoc' and '@harbour-enterprises/superdoc' on npm
  before dispatching; semantic-release's prepare phase pushes the v*
  tag before publish, so a publish failure that does not recover would
  otherwise notify on an unpublished version.
@caio-pizzol
caio-pizzol requested a review from a team as a code owner May 11, 2026 14:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fac6a01501

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/notify-homepage-superdoc-release.yml
@caio-pizzol
caio-pizzol merged commit e16ea64 into main May 11, 2026
13 checks passed
@caio-pizzol
caio-pizzol deleted the fix-notify-homepage-orchestrator branch May 11, 2026 16:26
msviderok pushed a commit to msviderok/superdoc that referenced this pull request May 16, 2026
…c#3229)

Stable superdoc releases now ship via release-stable.yml (named
'📦 Release stable tooling (CLI/SDK/MCP)'), so listening to
'📦 Release superdoc' on workflow_run silently stopped firing for
stable releases. Mirrors the trigger change already in place on
promote-stable-docs.yml.

- Trigger now matches the orchestrator workflow name.
- Accept conclusion: failure too, so a tools-chain failure following a
  successful superdoc release still notifies (chain-independent
  orchestrator semantics).
- Verify both 'superdoc' and '@harbour-enterprises/superdoc' on npm
  before dispatching; semantic-release's prepare phase pushes the v*
  tag before publish, so a publish failure that does not recover would
  otherwise notify on an unpublished version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant