Skip to content

Commit bb25255

Browse files
authored
Merge pull request #229 from switcherapi/staging
Removed RegexValidator Java 8 support
2 parents 106fc32 + 5870ca6 commit bb25255

6 files changed

Lines changed: 7 additions & 324 deletions

File tree

.github/workflows/master-2.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
with:
1818
fetch-depth: 0
1919

20-
- name: Set up JDK 17
20+
- name: Set up JDK 11
2121
uses: actions/setup-java@v3
2222
with:
23-
java-version: 17
23+
java-version: 11
2424
distribution: 'temurin'
2525
cache: maven
2626

@@ -34,7 +34,7 @@ jobs:
3434
strategy:
3535
fail-fast: false
3636
matrix:
37-
java: [ '17', '18']
37+
java: [ '11', '17', '18']
3838
os: [ ubuntu-latest, windows-latest ]
3939
runs-on: ${{ matrix.os }}
4040
if: "! contains(toJSON(github.event.commits.*.message), '[skip ci]')"

pom.xml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
<properties>
4747
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
4848
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
49-
<java.version>17</java.version>
49+
<java.version>11</java.version>
5050
<maven.compiler.source>${java.version}</maven.compiler.source>
5151
<maven.compiler.target>${java.version}</maven.compiler.target>
5252

@@ -166,12 +166,6 @@
166166
<artifactId>junit</artifactId>
167167
<version>4.13.1</version>
168168
</dependency>
169-
170-
<dependency>
171-
<groupId>com.fasterxml.jackson.core</groupId>
172-
<artifactId>jackson-databind</artifactId>
173-
<version>2.14.2</version>
174-
</dependency>
175169
</dependencies>
176170
</dependencyManagement>
177171

src/main/java/com/github/switcherapi/client/model/Entry.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ public int hashCode() {
6060

6161
@Override
6262
public boolean equals(Object obj) {
63-
if (obj instanceof Entry entry) {
63+
if (obj instanceof Entry) {
64+
Entry entry = (Entry) obj;
6465
if (!this.strategy.equals(entry.getStrategy())) {
6566
return false;
6667
}

src/main/java/com/github/switcherapi/client/service/ValidatorService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ private void initializeValidators() {
2626
registerValidator(PayloadValidator.class);
2727
registerValidator(TimeValidator.class);
2828
registerValidator(ValueValidator.class);
29-
registerValidator(RegexValidatorV8.getPlatformValidator());
29+
registerValidator(RegexValidator.class);
3030
}
3131

3232
private StrategyValidator getStrategyValidator(Class<? extends Validator> validatorClass) {

src/main/java/com/github/switcherapi/client/service/validators/RegexValidatorV8.java

Lines changed: 0 additions & 191 deletions
This file was deleted.

src/test/java/com/github/switcherapi/client/validator/RegexValidatorV8Test.java

Lines changed: 0 additions & 121 deletions
This file was deleted.

0 commit comments

Comments
 (0)