Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces a snapshot auto-update mechanism to the Switcher client, enabling periodic background updates of snapshots. It also refines context and authentication initialization, and improves the test suite to cover the new functionality. The most important changes are grouped below:
Snapshot Auto-Update Feature:
SnapshotAutoUpdaterclass to handle periodic snapshot updates in a background thread, with methods to schedule and terminate updates. (switcher_client/lib/snapshot_auto_updater.py)Clientclass to useSnapshotAutoUpdaterfor scheduling and terminating snapshot auto-updates, removing the previous check logic. (switcher_client/client.py) [1] [2] [3]Context and Authentication Improvements:
ContextOptionsandContextconstructors to use type annotations and improved parameter handling. (switcher_client/lib/globals/global_context.py)GlobalAuth.initandRemoteAuth.initto remove the unusedurlparameter. (switcher_client/lib/globals/global_auth.py,switcher_client/lib/remote_auth.py) [1] [2]