Commit f9f8a88
committed
bug #62813 [Console] Fix EofShortcut instruction when using a modern terminal on Windows (fperxas)
This PR was squashed before being merged into the 6.4 branch.
Discussion
----------
[Console] Fix EofShortcut instruction when using a modern terminal on Windows
| Q | A
| ------------- | ---
| Branch? | 6.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Issues | Fix #62514
| License | MIT
On `SymfonyQuestionHelper` use the `isDecoratedFlag` instead of the PHP_OS_FAMILY. `@nicolas`-grekas suggested to use `StreamOutput::hasColorSupport()`. As it is a protected method i thought we could use the `OutputInterface::isDecorated` flag which is constructed from `StreamOutput` like this: `$decorated ??= $this->hasColorSupport();`
Please review if it is a correct decision :)
Commits
-------
2cac8785e5f [Console] Fix EofShortcut instruction when using a modern terminal on Windows1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
0 commit comments