feat: Add ScanningAlertsClientV1 with support for Scanning Alerts #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tembleking
added a commit
that referenced
this pull request
Jul 11, 2022
* feat(scanning): Add support for runtime alert creation * feat(scanning): Add support for repository alert creation * ci(scanning): Add test that retrieves an alert * feat(scanning): Add support for runtime alert update * feat(scanning): Add support for repository alert update * refactor(scanning): Extract ScanningAlertsClientV1 client * docs: Add usage examples * docs: Add SdScanningClient documentation autogeneration * fix(lint): Expand imports * lint: Fix linting errors and add EditorConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method
add_alertdoesn't work correctly, because it lacks of atypefield, that's required, andupdate_alertis not very usable, because the user must understand how to modify it correctly.The new
add_repository_alert,add_runtime_alert,update_repository_alertandupdate_runtime_alertmethods are a bit easier to use and are correctly tested.