fix(userspace/libsinsp): added back add_container() calls for synchronous container engines.

Old behavior for sync engines was to load informations as quick as possible, without waiting
for the injected event to get parsed.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Author: FedeDP

userspace/libsinsp/container_engine/bpm.cpp

@@ -60,6 +60,7 @@ bool bpm::resolve(sinsp_threadinfo *tinfo, bool query_os_for_missing_info)
 	if(container_cache().should_lookup(container_info.m_id, CT_BPM))
 	{
 		container_info.m_name = container_info.m_id;
+		container_cache().add_container(std::make_shared<sinsp_container_info>(container_info), tinfo);
 		container_cache().notify_new_container(container_info, tinfo);
 	}
 	return true;

userspace/libsinsp/container_engine/libvirt_lxc.cpp

@@ -84,6 +84,7 @@ bool libvirt_lxc::resolve(sinsp_threadinfo *tinfo, bool query_os_for_missing_inf
 	if(container_cache().should_lookup(container.m_id, CT_LIBVIRT_LXC))
 	{
 		container.m_name = container.m_id;
+		container_cache().add_container(std::make_shared<sinsp_container_info>(container), tinfo);
 		container_cache().notify_new_container(container, tinfo);
 	}
 	return true;

userspace/libsinsp/container_engine/lxc.cpp

@@ -63,6 +63,7 @@ bool lxc::resolve(sinsp_threadinfo *tinfo, bool query_os_for_missing_info)
 	if (container_cache().should_lookup(container.m_id, CT_LXC))
 	{
 		container.m_name = container.m_id;
+		container_cache().add_container(std::make_shared<sinsp_container_info>(container), tinfo);
 		container_cache().notify_new_container(container, tinfo);
 	}
 	return true;

userspace/libsinsp/container_engine/mesos.cpp

@@ -61,6 +61,7 @@ bool libsinsp::container_engine::mesos::resolve(sinsp_threadinfo* tinfo, bool qu
 	if(container_cache().should_lookup(container.m_id, CT_MESOS))
 	{
 		container.m_name = container.m_id;
+		container_cache().add_container(std::make_shared<sinsp_container_info>(container), tinfo);
 		container_cache().notify_new_container(container, tinfo);
 	}
 	return true;

userspace/libsinsp/container_engine/rkt.cpp

@@ -189,6 +189,7 @@ bool rkt::rkt::resolve(sinsp_threadinfo* tinfo, bool query_os_for_missing_info)
 
 	if (have_rkt)
 	{
+		cache->add_container(std::make_shared<sinsp_container_info>(container), tinfo);
 		cache->notify_new_container(container, tinfo);
 		return true;
 	}