[Refactor] avoid needing a call-bound push

Author: ljharb

lib/results.js

@@ -12,7 +12,6 @@ var $exec = callBound('RegExp.prototype.exec');
 var $split = callBound('String.prototype.split');
 var $replace = callBound('String.prototype.replace');
 var $shift = callBound('Array.prototype.shift');
-var $push = callBound('Array.prototype.push');
 var yamlIndicators = /:|-|\?/;
 var nextTick = typeof setImmediate !== 'undefined'
 	? setImmediate
@@ -169,7 +168,7 @@ Results.prototype.createStream = function (opts) {
 };
 
 Results.prototype.push = function (t) {
-	$push(this.tests, t);
+	this.tests[this.tests.length] = t;
 	this._watch(t);
 	this.emit('_push', t);
 };

lib/test.js

@@ -25,7 +25,6 @@ var objectToString = callBound('Object.prototype.toString');
 var $split = callBound('String.prototype.split');
 var $replace = callBound('String.prototype.replace');
 var $strSlice = callBound('String.prototype.slice');
-var $push = callBound('Array.prototype.push');
 var $shift = callBound('Array.prototype.shift');
 var $slice = callBound('Array.prototype.slice');
 
@@ -155,7 +154,7 @@ Test.prototype.run = function run() {
 Test.prototype.test = function test(name, opts, cb) {
 	var self = this;
 	var t = new Test(name, opts, cb);
-	$push(this._progeny, t);
+	this._progeny[this._progeny.length] = t;
 	this.pendingCount++;
 	this.emit('test', t);
 	t.on('prerun', function () {
@@ -235,12 +234,12 @@ function wrapFunction(original) {
 			var completed = false;
 			try {
 				var returned = bound ? bound(this, arguments) : void undefined;
-				$push(calls, { args: args, receiver: this, returned: returned });
+				calls[calls.length] = { args: args, receiver: this, returned: returned };
 				completed = true;
 				return returned;
 			} finally {
 				if (!completed) {
-					$push(calls, { args: args, receiver: this, threw: true });
+					calls[calls.length] = { args: args, receiver: this, threw: true };
 				}
 			}
 		},
@@ -326,16 +325,16 @@ Test.prototype.intercept = function intercept(obj, property) {
 				try {
 					var returned = getter(this, arguments);
 					completed = true;
-					$push(calls, { type: 'get', success: true, value: returned, args: args, receiver: this });
+					calls[calls.length] = { type: 'get', success: true, value: returned, args: args, receiver: this };
 					return returned;
 				} finally {
 					if (!completed) {
-						$push(calls, { type: 'get', success: false, threw: true, args: args, receiver: this });
+						calls[calls.length] = { type: 'get', success: false, threw: true, args: args, receiver: this };
 					}
 				}
 			}
 		}
-		$push(calls, { type: 'get', success: true, value: value, args: args, receiver: this });
+		calls[calls.length] = { type: 'get', success: true, value: value, args: args, receiver: this };
 		return value;
 	}
 
@@ -346,19 +345,19 @@ Test.prototype.intercept = function intercept(obj, property) {
 			try {
 				var returned = setter(this, arguments);
 				completed = true;
-				$push(calls, { type: 'set', success: true, value: v, args: args, receiver: this });
+				calls[calls.length] = { type: 'set', success: true, value: v, args: args, receiver: this };
 				return returned;
 			} finally {
 				if (!completed) {
-					$push(calls, { type: 'set', success: false, threw: true, args: args, receiver: this });
+					calls[calls.length] = { type: 'set', success: false, threw: true, args: args, receiver: this };
 				}
 			}
 		}
 		var canSet = isAccessor || writable;
 		if (canSet) {
 			value = v;
 		}
-		$push(calls, { type: 'set', success: !!canSet, value: value, args: args, receiver: this });
+		calls[calls.length] = { type: 'set', success: !!canSet, value: value, args: args, receiver: this };
 
 		if (!canSet && strictMode) {
 			throw new TypeError('Cannot assign to read only property `' + inspect(property) + '` of object `' + inspect(obj) + '`');
@@ -855,7 +854,8 @@ Test.prototype['throws'] = function (fn, expected, msg, extra) {
 				var keys = objectKeys(expected);
 				// Special handle errors to make sure the name and the message are compared as well.
 				if (expected instanceof Error) {
-					$push(keys, 'name', 'message');
+					keys[keys.length] = 'name';
+					keys[keys.length] = 'message';
 				} else if (keys.length === 0) {
 					throw new TypeError('`throws` validation object must not be empty');
 				}