Skip to content

Commit ef08214

Browse files
committed
ci: put static code check into a separate job
With this approach static check failures don't block unit/integration tests. Closes TNTP-6083
1 parent 7dd32dc commit ef08214

File tree

2 files changed

+35
-16
lines changed

2 files changed

+35
-16
lines changed

.github/actions/static-code-check/action.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,20 @@ description: "Performs static code checks."
44
runs:
55
using: "composite"
66
steps:
7-
- name: Log versions
8-
run: |
9-
go version
10-
mage --version
11-
tarantool --version
12-
rpm --version
13-
shell: bash
7+
# - name: Setup python requirements
8+
# uses: ./.github/actions/prepare-python-env
149

15-
- name: License checker
16-
run: |
17-
go install github.com/uw-labs/lichen@latest
18-
mage checklicenses
10+
- uses: actions/checkout@master
11+
with:
12+
fetch-depth: 0
13+
14+
- name: Setup Go
15+
uses: actions/setup-go@v4
16+
with:
17+
go-version: '${{ env.GO_VERSION }}'
18+
19+
- name: Generate sources
20+
run: go run magefile.go GenerateGoCode
1921
shell: bash
2022

2123
- name: Find git base branch
@@ -24,6 +26,7 @@ runs:
2426
HASH=$(git log --format='%H^%D' | grep 'origin/' | head -n 2 | tail -n 1 | cut -f1 -d^)
2527
echo "Found base branch with hash: '${HASH}'"
2628
echo "BASE_BRANCH=${HASH}" >> ${GITHUB_ENV}
29+
echo "Python venv path: '${VIRTUAL_ENV}'"
2730
2831
- name: pre-commit checks (diff)
2932
uses: pre-commit/action@v3.0.1

.github/workflows/tests.yml

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,22 @@ jobs:
2626
- name: Check commit messages
2727
uses: ./.github/actions/check-commit-msg
2828

29+
static-code-check:
30+
if: github.event_name == 'push'
31+
runs-on: ubuntu-22.04
32+
steps:
33+
# - name: Install basic tools
34+
# run: |
35+
# sudo apt -y update
36+
# sudo apt -y install git
37+
38+
# - uses: actions/checkout@master
39+
# with:
40+
# fetch-depth: 0
41+
42+
- name: Static code check
43+
uses: ./.github/actions/static-code-check
44+
2945
tests-ce:
3046
if: |
3147
(github.event_name == 'push') ||
@@ -48,8 +64,11 @@ jobs:
4864
with:
4965
tarantool-version: '${{ matrix.tarantool-version }}'
5066

51-
- name: Static code check
52-
uses: ./.github/actions/static-code-check
67+
- name: License checker
68+
run: |
69+
go install github.com/uw-labs/lichen@latest
70+
mage checklicenses
71+
shell: bash
5372

5473
- name: Unit tests
5574
run: mage unit
@@ -138,9 +157,6 @@ jobs:
138157
sdk-version: '${{ matrix.sdk-version }}'
139158
sdk-download-token: '${{ secrets.SDK_DOWNLOAD_TOKEN }}'
140159

141-
- name: Static code check
142-
uses: ./.github/actions/static-code-check
143-
144160
- name: Unit tests
145161
run: mage unit
146162

0 commit comments

Comments
 (0)