fix(server): allow user input requests in default mode - #91
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 454f8bd1e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| The \`request_user_input\` tool is unavailable in Default mode. If you call it while in Default mode, it will return an error. | ||
|
|
||
| In Default mode, strongly prefer making reasonable assumptions and executing the user's request rather than stopping to ask questions. If you absolutely must ask a question because the answer cannot be discovered from local context and a reasonable assumption would be risky, ask the user directly with a concise plain-text question. Never write a multiple choice question as a textual assistant message. | ||
| In Default mode, strongly prefer making reasonable assumptions and executing the user's request rather than stopping to ask questions. If you must ask a question because the answer cannot be discovered from local context and a reasonable assumption would be risky, use the \`request_user_input\` tool when it is available. Otherwise, ask the user directly with a concise plain-text question. Never write a multiple-choice question as a textual assistant message. |
There was a problem hiding this comment.
Add focused coverage for default-mode input instructions
This backend behavior change determines whether default-mode Codex uses the UI-backed input flow, but no focused test asserts that the generated instructions permit request_user_input when available and retain the plain-text fallback. The existing builder tests only cover the mode prefix, runtime metadata, and browser instructions, so a later upstream sync could silently restore the blanket-unavailable behavior; add explicit regression assertions for both clauses.
AGENTS.md reference: AGENTS.md:L108-L113
Useful? React with 👍 / 👎.
What Changed
Default-mode developer instructions now use
request_user_inputwhen it is configured. When the tool is absent, agents fall back to a concise plain-text question.FORK.mdrecords the fork-specific behavior.Why
Tool availability is configurable, so treating it as unavailable in every Default mode session prevented agents from using it even when exposed.
Checklist