Skip to content

fix(server): preserve root agent activity - #98

Merged
tarik02 merged 1 commit into
mainfrom
fix/root-agent-reasoning-filter
Jul 30, 2026
Merged

fix(server): preserve root agent activity#98
tarik02 merged 1 commit into
mainfrom
fix/root-agent-reasoning-filter

Conversation

@tarik02

@tarik02 tarik02 commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Filter child conversation notifications only for provider thread IDs learned from collabAgentToolCall or subAgentActivity.
  • Document that root-agent activity stays visible.

Why

The provider-thread mismatch heuristic could classify a resumed root thread as a child. That kept allowlisted commands and file changes while dropping root messages and reasoning. Explicit child relationships already identify the notifications that need filtering.

Checklist

  • This PR is small and focused
  • I explained what changed and why

gpt-5.6-sol via T3 Code.

@github-actions github-actions Bot added size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Jul 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a107c7531

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

providerThreadId !== rootProviderThreadId);

if (belongsToChild && !shouldKeepChildNotification(notification)) {
if (childParentTurnId !== undefined && !shouldKeepChildNotification(notification)) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add regression tests for root and child notification routing

This changes backend notification classification without adding focused coverage; the existing CodexSessionRuntime.test.ts suite does not exercise root-versus-child routing. Add cases proving that a mismatched resumed-root thread retains messages/reasoning while explicitly discovered child threads suppress conversation events but retain allowed activity, so this fix cannot silently reintroduce either regression.

AGENTS.md reference: AGENTS.md:L101-L101

Useful? React with 👍 / 👎.

@tarik02
tarik02 merged commit 423617f into main Jul 30, 2026
10 checks passed
@tarik02
tarik02 deleted the fix/root-agent-reasoning-filter branch July 30, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant