From 372c6c8f7166fe9dd0fc81adcaa1801291143f68 Mon Sep 17 00:00:00 2001 From: "Dustin J. Mitchell" Date: Tue, 13 Nov 2018 21:48:41 +0000 Subject: [PATCH] Remove mention of automatic use of env vars from RFC#128 This introduced a breaking change, and was not widely circulated among users during the RFC discussion process. Since it is largely orthogonal to this RFC, we will move it to another, fresh RFC for discussion. --- rfcs/0128-redeployable-clients.md | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/rfcs/0128-redeployable-clients.md b/rfcs/0128-redeployable-clients.md index b649f2f..7b2c5af 100644 --- a/rfcs/0128-redeployable-clients.md +++ b/rfcs/0128-redeployable-clients.md @@ -432,21 +432,11 @@ definitions change. ## 4.7 Changes to taskcluster client features and configuration -Constructors for clients should require the rootURL to be explicitly provided, -i.e. no default. This is in order to ensure that the choice of deployed cluster -to connect to is an active one. The client may provide a utility methods to fetch -`TASKCLUSTER_ROOT_URL` from the environment, but it should not be assumed that if -this environment variable exists, that it should be used. Rather, code that calls -the taskcluster client should have to explicitly declare they wish to do so, for -example: +When accepting configuration, clients will expect a root URL as well as the +usual credentials. Since there is no "default cluster", there is no default +for the root URL. -``` -queue := queue.NewFromEnvVars() -``` - -This is important because not all code will want to configure settings based on -environment variables, for example workers that take their configuration from -configuration files. +How this configuration is received by the client is not covered by this RFC. ## 4.8 Changes to services that depend on taskcluster client