From c30146d7897e2a42caf91b29ca559bf0728ca211 Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 20:58:48 +0200 Subject: [PATCH 1/6] Omit 4.08 on macOS and Windows from CI --- .github/workflows/build-test.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 3c92918..90cdc30 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -18,6 +18,11 @@ jobs: ocaml-version: - 4.8 - 5.3 + exclude: + - os: macos-latest + ocaml-compiler: "4.08" + - os: windows-latest + ocaml-compiler: "4.08" runs-on: ${{ matrix.os }} From 1204f497f77911012c606825ee9ebcf1e273aef6 Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 21:00:40 +0200 Subject: [PATCH 2/6] Add 4.14 to CI matrix as a pre-5.x representative version --- .github/workflows/build-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 90cdc30..90f9c2a 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -17,6 +17,7 @@ jobs: - windows-latest ocaml-version: - 4.8 + - 4.14 - 5.3 exclude: - os: macos-latest From bcc6068454694d971ab675fb90d8999843dcd313 Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 21:15:14 +0200 Subject: [PATCH 3/6] List pull_request first --- .github/workflows/build-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 90f9c2a..07187b9 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -1,10 +1,10 @@ name: Build and Test on: + pull_request: push: branches: - master - pull_request: jobs: build-and-test: From 5c31251fb0953293b1e2e79e90eeddd7745dad14 Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 21:18:27 +0200 Subject: [PATCH 4/6] Fix mismatch between versions specified and quote version --- .github/workflows/build-test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 07187b9..bef389e 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -16,9 +16,9 @@ jobs: - ubuntu-latest - windows-latest ocaml-version: - - 4.8 - - 4.14 - - 5.3 + - "4.08" + - "4.14" + - "5.3" exclude: - os: macos-latest ocaml-compiler: "4.08" From 83c1017ecc39783f91216d9e011439e02f000bc3 Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 21:20:00 +0200 Subject: [PATCH 5/6] ocaml-version in matrix, not ocaml-compiler --- .github/workflows/build-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index bef389e..696bb68 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -21,9 +21,9 @@ jobs: - "5.3" exclude: - os: macos-latest - ocaml-compiler: "4.08" + ocaml-version: "4.08" - os: windows-latest - ocaml-compiler: "4.08" + ocaml-version: "4.08" runs-on: ${{ matrix.os }} From 6788635f792a8f9aa9c59829ddef49778134276a Mon Sep 17 00:00:00 2001 From: Jan Midtgaard Date: Mon, 29 Sep 2025 21:39:40 +0200 Subject: [PATCH 6/6] Only explore lower bounds on Linux --- .github/workflows/build-test.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml index 696bb68..b21039a 100644 --- a/.github/workflows/build-test.yml +++ b/.github/workflows/build-test.yml @@ -46,10 +46,14 @@ jobs: - name: run test run: opam exec -- dune runtest - - run: opam install . --deps-only --with-test --criteria='+removed,+count[version-lag,solution]' --solver=builtin-0install + - name: install lower bounds version + if: matrix.os == 'ubuntu-latest' + run: opam install . --deps-only --with-test --criteria='+removed,+count[version-lag,solution]' --solver=builtin-0install - name: build project with lower bounds + if: matrix.os == 'ubuntu-latest' run: opam exec -- dune build - name: run test with lower bounds + if: matrix.os == 'ubuntu-latest' run: opam exec -- dune runtest