fix: page router T1331#2299
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a page router issue (T1331) by adding validation logic to handle invalid dashboard IDs and includes localization updates for new app-related error messages.
- Adds validation to redirect users to valid dashboards when provided dashboard ID doesn't exist
- Removes unnecessary schema prefix from SQL migration file
- Adds comprehensive i18n translations for app-related error messages across 10 languages
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/nextjs-app/src/features/app/base-node/DashBoardPage.tsx | Adds validation logic to check if provided dashboardId exists in the dashboard list and redirects to the first available dashboard if not |
| packages/db-main-prisma/prisma/postgres/migrations/20251210134101_disallow_dashboard/migration.sql | Removes unnecessary "public" schema prefix from INSERT statement |
| packages/common-i18n/src/locales/*/sdk.json | Adds new "app" section with 11 error message translations for app-related operations across all supported languages (en, de, es, fr, it, ja, ru, tr, uk, zh) |
| apps/nestjs-backend/src/types/i18n.generated.ts | Updates TypeScript type definitions to include new app error message keys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
younocode
force-pushed
the
fix/page-router
branch
from
3ac3ecf to
93aab91
Compare
Collaborator
Pull Request Test Coverage Report for Build 20357722436Details
💛 - Coveralls |
younocode
force-pushed
the
fix/page-router
branch
from
93aab91 to
5e0865f
Compare
boris-w
approved these changes
Dec 19, 2025
Contributor
🧹 Preview Environment Cleanup
|
hammond-lj
pushed a commit
that referenced
this pull request
Dec 22, 2025
* fix: page router * fix: update SQL migration to remove schema prefix from setting table * feat: add app-related translations for multiple languages * refactor: simplify e2e tests * refactor: update e2e tests to use cached settings for improved performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues: T1331