fix: improve side filtering to match tokens rather than substrings#10
Merged
Merged
Conversation
slight reformat + add also to plot_subcortical
Owner
|
Thanks! I did a minor edit to one line and also replicated same approach to plot_subcortical() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled on a small issue with side filtering when plotting commissural bundles: when the bundle filename contained

r_orl_, it was incorrectly assigned to a hemisphere, whereas it should appear in both. See below for an example where the filename wasCC_Fr_1.trk:I simply changed how side filtering was performed: tokenize the filename, then match side patterns. It now does not catch trailing substrings (e.g.,

r_orl_):The filtering steps also still work for truly lateralized bundles (assuming either
left,right,l,r,lh, orrhis in the filename).