Skip to content

Commit 2988005

Browse files
dejan2609tedyu
authored andcommitted
KAFKA-12770 introduce checkstyleVersion gradle property (for overriding CheckStyle project-defined dependency version) (apache#10967)
Reviewers: Ken Huang <s7133700@gmail.com>, Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
1 parent c15f6ef commit 2988005

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ You can run checkstyle using:
177177

178178
The checkstyle warnings will be found in `reports/checkstyle/reports/main.html` and `reports/checkstyle/reports/test.html` files in the
179179
subproject build directories. They are also printed to the console. The build will fail if Checkstyle fails.
180+
For experiments (or regression testing purposes) add `-PcheckstyleVersion=X.y.z` switch (to override project-defined checkstyle version).
180181

181182
#### Spotless ####
182183
The import order is a part of static check. please call `spotlessApply` to optimize the imports of Java codes before filing pull request.

gradle/dependencies.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ versions += [
6161
// when updating checkstyle, check whether the exclusion of
6262
// CVE-2023-2976 and CVE-2020-8908 can be dropped from
6363
// gradle/resources/dependencycheck-suppressions.xml
64-
checkstyle: "8.36.2",
64+
checkstyle: project.hasProperty('checkstyleVersion') ? checkstyleVersion : "8.36.2",
6565
commonsCli: "1.4",
6666
commonsIo: "2.14.0", // ZooKeeper dependency. Do not use, this is going away.
6767
commonsValidator: "1.9.0",

0 commit comments

Comments
 (0)