From c5a9fc9dc51dcfc690b5a3a7a6f2defcac5c25ee Mon Sep 17 00:00:00 2001 From: Abhinav Nekkanti <10552725+anekkanti@users.noreply.github.com> Date: Fri, 21 Nov 2025 10:30:32 -0800 Subject: [PATCH 1/3] Refinement of comments around namespace capacity --- .github/workflows/build.yaml | 2 ++ temporal/api/cloud/namespace/v1/message.proto | 25 +++++++++++-------- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 76f49c86..70c84148 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -11,6 +11,8 @@ jobs: check-latest: true - name: Install Protoc uses: arduino/setup-protoc@v2 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} - name: Validate and build go bindings from the proto files run: make ci-build env: diff --git a/temporal/api/cloud/namespace/v1/message.proto b/temporal/api/cloud/namespace/v1/message.proto index 14ee15f2..dd053f84 100644 --- a/temporal/api/cloud/namespace/v1/message.proto +++ b/temporal/api/cloud/namespace/v1/message.proto @@ -95,9 +95,9 @@ message HighAvailabilitySpec { // temporal:versioning:min_version=v0.10.0 message CapacitySpec { oneof spec { - // on-demand capacity (dynamic-envelope) + // The on-demand capacity mode configuration. OnDemand on_demand = 1; - // provisioned capacity + // The provisioned capacity mode configuration. Provisioned provisioned = 2; } @@ -105,7 +105,8 @@ message CapacitySpec { } message Provisioned { - // the unit of the provisioned capacity (Temporal Resource Units) + // The unit of the provisioned capacity in Temporal Resource Units. + // TODO: expand on this. double value = 1; } } @@ -113,9 +114,9 @@ message CapacitySpec { message Capacity { oneof current_mode { - // the current capacity is on-demand + // The status of on-demand capacity mode. OnDemand on_demand = 1; - // the current capacity is provisioned + // The status of provisioned capacity mode. Provisioned provisioned = 2; } @@ -123,12 +124,13 @@ message Capacity { } message Provisioned { - // the current unit of the provisioned capacity (Temporal Resource Units) + // The current provisioned capacity for the namespace in Temporal Resource Units. + // Can be different from the requested capacity in latest_request if the request is still in progress. double current_value = 1; } message Request { - // the current state of the capacity request (e.g. in-progress, completed, failed) + // The current state of the capacity request (e.g. in-progress, completed, failed). State state = 1; // The date and time when the capacity request was created. google.protobuf.Timestamp start_time = 2; @@ -147,7 +149,7 @@ message Capacity { } } - // The latest capacity request, if any. + // The latest requested capacity for the namespace, if any. Request latest_request = 3; } @@ -209,6 +211,9 @@ message NamespaceSpec { repeated string connectivity_rule_ids = 11; // The capacity configuration for the namespace. + // There are two capacity modes: on-demand and provisioned. + // On-demand capacity mode allows the namespace to scale automatically based on usage. + // Provisioned capacity mode allows the user to specify a fixed amount of capacity (in TRUs) for the namespace. // temporal:versioning:min_version=v0.10.0 CapacitySpec capacity_spec = 12; @@ -292,11 +297,9 @@ message Namespace { map region_status = 12; // The connectivity rules that are set on this namespace. repeated temporal.api.cloud.connectivityrule.v1.ConnectivityRule connectivity_rules = 14; - // The tags for the namespace. map tags = 15; - - // The capacity of the namespace. + // The status of namespace's capacity, if any. Capacity capacity = 16; } From e5e706e9155048fa8140872572eb49b30bf4b433 Mon Sep 17 00:00:00 2001 From: Abhinav Nekkanti <10552725+anekkanti@users.noreply.github.com> Date: Fri, 21 Nov 2025 10:36:57 -0800 Subject: [PATCH 2/3] more minor updates --- temporal/api/cloud/namespace/v1/message.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/temporal/api/cloud/namespace/v1/message.proto b/temporal/api/cloud/namespace/v1/message.proto index dd053f84..a6c12994 100644 --- a/temporal/api/cloud/namespace/v1/message.proto +++ b/temporal/api/cloud/namespace/v1/message.proto @@ -112,7 +112,6 @@ message CapacitySpec { } message Capacity { - oneof current_mode { // The status of on-demand capacity mode. OnDemand on_demand = 1; @@ -214,6 +213,7 @@ message NamespaceSpec { // There are two capacity modes: on-demand and provisioned. // On-demand capacity mode allows the namespace to scale automatically based on usage. // Provisioned capacity mode allows the user to specify a fixed amount of capacity (in TRUs) for the namespace. + // Can be changed only when the last capacity request is not in progress. // temporal:versioning:min_version=v0.10.0 CapacitySpec capacity_spec = 12; From 17b4556b400e5006b8590ba67df28a15ea1c11d1 Mon Sep 17 00:00:00 2001 From: Abhinav Nekkanti <10552725+anekkanti@users.noreply.github.com> Date: Fri, 21 Nov 2025 11:26:55 -0800 Subject: [PATCH 3/3] Some minor improvements --- temporal/api/cloud/namespace/v1/message.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/temporal/api/cloud/namespace/v1/message.proto b/temporal/api/cloud/namespace/v1/message.proto index a6c12994..74a9f418 100644 --- a/temporal/api/cloud/namespace/v1/message.proto +++ b/temporal/api/cloud/namespace/v1/message.proto @@ -105,8 +105,8 @@ message CapacitySpec { } message Provisioned { - // The unit of the provisioned capacity in Temporal Resource Units. - // TODO: expand on this. + // The units of provisioned capacity in TRU (Temporal Resource Units). + // Each TRU unit assigned to the namespace will entitle it with additional APS limits as specified in the documentation. double value = 1; } }