Skip to content

Commit 63c4955

Browse files
authored
fix(deps)!: replace eslint-plugin-eslint-comments with the @eslint-community version (#1091)
* fix(deps)!: replace eslint-plugin-eslint-comments with @eslint-community version * fix(deps)!: update @eslint-community/eslint-plugin-eslint-comments to the latest
1 parent f7875a1 commit 63c4955

File tree

6 files changed

+28
-36
lines changed

6 files changed

+28
-36
lines changed

package-lock.json

Lines changed: 16 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@
4242
"test:unit": "mocha test"
4343
},
4444
"dependencies": {
45+
"@eslint-community/eslint-plugin-eslint-comments": "^4.1.0",
4546
"@eslint/js": "^8.52.0",
4647
"@types/eslint": "^8.44.6",
4748
"@typescript-eslint/eslint-plugin": "^6.9.0",
4849
"@typescript-eslint/parser": "^6.9.0",
4950
"deepmerge": "^4.3.1",
5051
"eslint-import-resolver-typescript": "^3.6.1",
51-
"eslint-plugin-eslint-comments": "^3.2.0",
5252
"eslint-plugin-import": "^2.29.0",
5353
"eslint-plugin-jsdoc": "^46.8.2",
5454
"eslint-plugin-n": "^16.2.0",

src/configs/base.ts

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
import comments from "@eslint-community/eslint-plugin-eslint-comments";
12
import js from "@eslint/js";
2-
import comments from "eslint-plugin-eslint-comments";
33
import jsdoc from "eslint-plugin-jsdoc";
44
import unicorn from "eslint-plugin-unicorn";
55
import { merge } from "../merge.js";
@@ -14,10 +14,10 @@ export const base = merge(js.configs.recommended, {
1414
// They may be referenced by other config files.
1515
unicorn,
1616
jsdoc,
17-
"eslint-comments": comments,
17+
"@eslint-community/eslint-comments": comments,
1818
},
1919
linterOptions: {
20-
// replace "eslint-comments/no-unused-disable" but warn only
20+
// replace "eslint-comments/no-unused-disable" but warn only now
2121
reportUnusedDisableDirectives: true,
2222
},
2323
rules: {
@@ -127,11 +127,14 @@ export const base = merge(js.configs.recommended, {
127127
"no-extra-semi": 0,
128128
"no-mixed-spaces-and-tabs": 0,
129129

130-
// # eslint-plugin-eslint-comments
131-
// https://github.com/mysticatea/eslint-plugin-eslint-comments
132-
"eslint-comments/disable-enable-pair": [2, { allowWholeFile: true }],
130+
// # @eslint-community/eslint-plugin-eslint-comments
131+
// https://github.com/eslint-community/eslint-plugin-eslint-comments
132+
"@eslint-community/eslint-comments/disable-enable-pair": [
133+
2,
134+
{ allowWholeFile: true },
135+
],
133136
// overwrite recommended
134-
"eslint-comments/no-unlimited-disable": 0,
137+
"@eslint-community/eslint-comments/no-unlimited-disable": 0,
135138

136139
// # eslint-plugin-unicorn
137140
// https://github.com/sindresorhus/eslint-plugin-unicorn
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
declare module "@eslint-community/eslint-plugin-eslint-comments";

src/types/eslint-plugin-eslint-comments.d.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/fixtures/es2021.eslint-comments#no-duplicate-disable.fail.js renamed to test/fixtures/es2021.@eslint-community#eslint-comments#no-duplicate-disable.fail.js

File renamed without changes.

0 commit comments

Comments
 (0)