Skip to content

add fine-grained resource for service perimeter resource#5574

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-3f0be871e0408c44270ab9361b9f826d3845e889
Feb 3, 2020
Merged

add fine-grained resource for service perimeter resource#5574
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-3f0be871e0408c44270ab9361b9f826d3845e889

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Fixes #4509.

In order to do this I had to make some changes to nested_query to allow it to add/remove an element of an array which is part of a nested object. I got it to work in this case by wrapping the object down the chain, so the patch request in this case would look like:

{
  "status": {
    "resources": [...]
  }
}

Notably, this doesn't merge the resources block into the status object that was returned from the API, but instead just wraps it. This works fine in this case because this API uses an update mask, so it can modify resources without changing anything else within status, but isn't future-proof if a similarly nested resource comes along that doesn't use an update mask.

Release Note Template for Downstream PRs (will be copied)

`google_access_context_manager_service_perimeter_resource`

Derived from GoogleCloudPlatform/magic-modules#3052

)

* add fine-grained resource for service perimeter resource

* exclude from inspec

* add sidebar entry and change acctest import

* comments, readability

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 470eafb into hashicorp:master Feb 3, 2020
@ghost
Copy link
Copy Markdown

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
@modular-magician modular-magician deleted the downstream-pr-3f0be871e0408c44270ab9361b9f826d3845e889 branch November 16, 2024 23:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add granular VPC Service-Control resource

1 participant