Skip to content

Commit 45f25bd

Browse files
committed
add note about potentially using LLL-reduction in nigglibasis one day
1 parent 0966a6c commit 45f25bd

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

Bravais/src/niggli.jl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,14 @@ function nigglibasis(
7474
# tolerance
7575
D = 3 # algorithm assumes 3D setting (TODO: extend to 2D?)
7676
ϵ = rtol * abs(volume(Rs))^(1/D)
77+
78+
# NB: it would make sense in principle to start by doing a conventional lattice
79+
# reduction step here, e.g., `lll` from LLLplus.jl, to make sure we have a good
80+
# "starting point" for the algorithm; this would mean we'd need to do fewer of the
81+
# iterations below, especially for very skewed input. But LLLplus.jl is not very
82+
# fast - usually slower than `nigglibasis` itself, so don't do it for now.
83+
# Rs_lll = lll(stack(Rs))[1] # LLL-reduced basis
84+
# Rs = DirectBasis(eachcol(Rs))
7785

7886
# initialization
7987
A, B, C, ξ, η, ζ = niggli_parameters(Rs)

0 commit comments

Comments
 (0)