MainMenu should respect the template parameter (fixes iommirocks#708)

Author: boxed

iommi/main_menu.py

@@ -97,9 +97,8 @@ def bind(self, request):
         style = resolve_style(None)
         conf = RefinableNamespace(*style.resolve(self))
 
-        template = conf.pop('template', 'iommi/main_menu/menu.html')
         if self.template is MISSING:
-            template = template
+            self.template = conf.pop('template', 'iommi/main_menu/menu.html')
 
         assets = {
             k: v.bind(request=request)
@@ -115,7 +114,7 @@ def bind(self, request):
             self,
             request,
             attrs=attrs,
-            template=template,
+            template=self.template,
             assets=assets,
         )
 

iommi/main_menu__tests.py

@@ -339,6 +339,20 @@ def decode_artist(string, **_):
         ), "Not forbidden to access M with `params`, whose `include` uses them to deny access."
 
 
+def test_main_menu_template():
+    # Regression test for https://github.com/iommirocks/iommi/issues/708
+    menu = MainMenu(
+        template=Template('<div>custom main menu template</div>'),
+        items=dict(
+            foo=M(
+                view=fake_view,
+            ),
+        ),
+    ).bind(request=req('get'))
+
+    assert '<div>custom main menu template</div>' in str(menu)
+
+
 def test_m_template():
     menu = MainMenu(
         items=dict(