Project green

Author: Johan Lübcke

conftest.py

@@ -48,7 +48,7 @@ def reset_sequences(request, django_db_blocker):
             cursor.execute("SELECT name FROM sqlite_master WHERE type='table'")
             for i, (table,) in enumerate(cursor.fetchall()):
                 cursor.execute(f"""
-                    INSERT INTO SQLITE_SEQUENCE (name,seq) SELECT '{table}', {(i + 1) * 1000} WHERE NOT EXISTS 
+                    INSERT INTO SQLITE_SEQUENCE (name,seq) SELECT '{table}', {(i + 1) * 1000} WHERE NOT EXISTS
                         (SELECT changes() AS change FROM sqlite_sequence WHERE change <> 0);
                     """)
 

examples/examples/form_examples.py

@@ -113,7 +113,10 @@ class MyForm(Form):
 
 @example(gettext("Custom actions can be added to forms"))
 def form_example_6(request):
-    do_nothing = lambda **_: None
+    @staticmethod
+    def do_nothing(**_):
+        return None
+
     return Form.edit(
         auto__instance=Artist.objects.all().first(),
         actions=dict(

examples/examples/supernaut.py

@@ -55,7 +55,11 @@ class AlbumTable(Table):
     class Meta:
         auto__model = Album
         page_size = 20
-        columns__name__cell__url = lambda row, **_: row.get_absolute_url()
+
+        @staticmethod
+        def columns__name__cell__url(row, **_):
+            return row.get_absolute_url()
+
         columns__name__filter__include = True
         columns__year__filter__include = True
         columns__year__filter__field__include = False
@@ -72,7 +76,11 @@ class Meta:
 class ArtistTable(Table):
     class Meta:
         auto__model = Artist
-        columns__name__cell__url = lambda row, **_: row.get_absolute_url()
+
+        @staticmethod
+        def columns__name__cell__url(row, **_):
+            return row.get_absolute_url()
+
         columns__name__filter__include = True
 
 

examples/examples/views.py

@@ -239,7 +239,10 @@ def get_absolute_url():
 class ShortcutSelectorForm(Form):
     class Meta:
         attrs__method = 'get'
-        actions__submit__post_handler = lambda **_: None
+
+        @staticmethod
+        def actions__submit__post_handler(**_):
+            return None
 
     shortcut = Field.multi_choice(
         choices=[

iommi/_web_compat.py

@@ -1,9 +1,17 @@
+from django.conf import settings
 from django.core.exceptions import (
     ImproperlyConfigured,
+    ValidationError,  # noqa: F401
 )
+from django.core.validators import URLValidator, validate_email  # noqa: F401
 from django.http import (
+    HttpRequest,  # noqa: F401
+    HttpResponse,  # noqa: F401
+    HttpResponseRedirect,  # noqa: F401
     QueryDict,  # noqa: F401
 )
+from django.http.response import HttpResponseBase  # noqa: F401
+from django.shortcuts import render  # noqa: F401
 from django.template import RequestContext
 from django.template.backends.django import Template as DjangoLoadedTemplate
 from django.template.context_processors import csrf as csrf_
@@ -13,13 +21,14 @@
     render_to_string,
 )
 from django.template.utils import InvalidTemplateEngineError
+from django.utils.encoding import smart_str  # noqa: F401
 from django.utils.html import format_html as django_format_html
 from django.utils.safestring import mark_safe
+from django.utils.text import slugify  # noqa: F401
 
 DjangoTemplate = None
 JinjaTemplate = None
 
-from django.conf import settings
 
 template_types = tuple()
 
@@ -48,7 +57,7 @@ class Template:
     def __init__(self, template_string):
         self.s = template_string
 
-    def render(self, context):
+    def render(self, context):  # noqa: F811
         if DjangoTemplate is not None:
             return DjangoTemplate(self.s).render(context=context)
         else:

iommi/_web_compat_flask.py

@@ -5,19 +5,19 @@ def __init__(self, environ):
         self.r = Request(environ)
 
     @property
-    def POST(self):
+    def POST(self):  # noqa: N802
         return self.r.form
 
     @property
-    def GET(self):
+    def GET(self):  # noqa: N802
         return self.r.args
 
     @property
     def method(self):
         return self.r.method
 
     @property
-    def META(self):
+    def META(self):  # noqa: N802
         return self.r.environ
 
     def is_ajax(self):

iommi/action.py

@@ -196,7 +196,7 @@ def group_actions(actions: Dict[str, Action]):
 
     grouped_actions: List[Tuple[str, str, List[Action]]] = [
         (group_name, slugify(group_name), list(actions_in_group))
-        for group_name, actions_in_group in groupby(actions_with_group, key=lambda l: l.group)
+        for group_name, actions_in_group in groupby(actions_with_group, key=lambda x: x.group)
     ]
 
     for _, _, actions_in_group in grouped_actions:

iommi/admin.py

@@ -340,7 +340,7 @@ def rows(admin, request, included_filter=False, **_):
                         app_name=app_name,
                         model_name=app_name,
                         name=model._meta.verbose_name_plural.capitalize(),
-                        url='%s/%s/' % (app_name, model_name),
+                        url='{}/{}/'.format(app_name, model_name),
                         format=lambda row, **_: row.name,
                         key=key,
                     )

iommi/debug.py

@@ -133,9 +133,12 @@ class Meta:
             """
             )
             sortable = False
-            row__attrs__class__included = lambda row, **_: row.included
             page_size = None
 
+            @staticmethod
+            def row__attrs__class__included(row, **_):
+                return row.included
+
         dunder_path = Column(
             cell__value=lambda row, **_: row.dunder_path,
             cell__format=dunder_path__format,
@@ -204,7 +207,7 @@ def local_debug_url_builder(filename, lineno):
         filename = join(settings.BASE_DIR, filename)
     if hasattr(settings, 'IOMMI_DEBUG_URL_MAPPING'):
         filename = filename.replace(*settings.IOMMI_DEBUG_URL_MAPPING)
-    return "pycharm://open?file=%s" % (filename,) + ('' if lineno is None else "&line=%d" % (lineno,))
+    return f"pycharm://open?file={filename}" + ('' if lineno is None else f"&line={lineno:d}")
 
 
 def src_debug_url_builder(filename, lineno=None):

iommi/debug__tests.py

@@ -41,7 +41,9 @@ class NestedPage(Page):
         foo = 'foo'
 
         class Meta:
-            endpoints__fisk__func = lambda **_: None
+            @staticmethod
+            def endpoints__fisk__func(**_):
+                return None
 
     class MyPage(Page):
         bar = 'bar'