Skip to content

Commit 5c096e6

Browse files
committed
Update CONTRIBUTING.md notes [skip ci]
We have CI set up with GitHub Actions now.
1 parent dab0623 commit 5c096e6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Run on changed files with:
4646

4747
```
4848
isort -rc edited_file_or_folder
49-
black --line-length 100 --target-version py35 edited_file_or_folder
49+
black --line-length 100 --target-version py39 edited_file_or_folder
5050
```
5151

5252
Or use directly the provided script `toolchain/autoformat` for this.
@@ -61,19 +61,19 @@ cd .git/hooks && ln -sf ../../toolchain/pre-commit-autoformat pre-commit
6161

6262
## Testing
6363

64-
We don't have CI support, yet. Please make sure all tests under the `tests` folder pass in your
65-
branch. Run tests with, from the root of the project:
64+
Please make sure all tests under the `tests` folder pass in your
65+
branch. Run tests from the root of the project with:
6666

6767
```
6868
python3 -m unittest discover -p 'Test*.py' tests
6969
```
7070

7171
All of the tests for the various image sources actually access the image source, so these
72-
could fail sometimes when the remote site is down for maintenance - use common sense for whether
73-
your changes caused the failure or it failed because of ax external reason.
72+
could fail when the remote site is down for maintenance or the downloader is out of date.
73+
It's okay to skip them if your changes are unrelated to those failures.
7474

7575
Please note the test suite is not yet very extensive, and also does not cover any of the UI
76-
aspects of Variety - always do some manual tests before you consider your PR is complete.
76+
aspects of Variety - if your changes are in this area, you should test it manually before you consider your PR complete.
7777

7878
## Editing UI files
7979
We have used Glade to develop the GTK UI dialogs of Variety.

0 commit comments

Comments
 (0)