Fixed #5672: fixed the tree indentation issue caused by the expansion icon#5677
Merged
jbicker merged 1 commit intoeclipse-theia:masterfrom Jul 10, 2019
Merged
Fixed #5672: fixed the tree indentation issue caused by the expansion icon#5677jbicker merged 1 commit intoeclipse-theia:masterfrom
jbicker merged 1 commit intoeclipse-theia:masterfrom
Conversation
…the expansion toggle icon - Fixed the indentation alignment issue in tree by adjusting the padding of the expansion toggle icon. Signed-off-by: fangnx <naxin.fang@ericsson.com>
vince-fugnitto
approved these changes
Jul 9, 2019
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
It looks good to me :)
Member
|
@vince-fugnitto please be more specific. What did you test? It is very generic functionality, we should look at all possible trees to make sure that they look good it. If you did it please merge. |
akosyakov
added
tree
jbicker
approved these changes
Jul 10, 2019
Contributor
jbicker
left a comment
jbicker
left a comment
There was a problem hiding this comment.
LGTM. I have looked into the other trees and did not see any ui glitches.
Member
Sorry, I looked in general to trees that have collapsable nodes and nodes with icons, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
See #5672.
With this patch: