Fixed #5732, #5735: fixed box-shadow and background-color in quick-open menu #5733
Merged
vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom Jul 23, 2019
Merged
Fixed #5732, #5735: fixed box-shadow and background-color in quick-open menu #5733vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
box-shadow and background-color in quick-open menu #5733vince-fugnitto merged 2 commits intoeclipse-theia:masterfrom
Conversation
fangnx
force-pushed
the
fnx-fix-5732
branch
2 times, most recently
from
d6a9362 to
7eaa191
Compare
…pport dark theme - This patch added dark-theme support for the `box-shadow` on the quick-open menu. To be aligned with VS Code and the current UI, the top divider (shadow) would be black in the dark theme and light-grey in the light theme. Signed-off-by: fangnx <naxin.fang@ericsson.com>
… with other widgets - Aligned the background color of quick-open menu with other widgets (e.g. the side-panel widget). This would also make the top shadow line more visible in the dark mode. Signed-off-by: fangnx <naxin.fang@ericsson.com>
fangnx
changed the title
box-shadow in quick-open menu to support dark themebox-shadow and background-color in quick-open menu
vince-fugnitto
approved these changes
Jul 17, 2019
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
It looks much better now thank you! 👍
Member
|
@jbicker would you like to take a look as well or shall I merge? :) |
Contributor
|
merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box-shadowon the quick-open menu. To be aligned with VS Code and the current UI, the top divider (shadow) would be black in the dark theme and light-grey in the light theme.background-colorof the quick-open menu with other widgets (e.g. the side-panel widget). This would also make the top shadow line more visible in the dark mode.Before
After