process: display process tasks in the terminal#5895
Conversation
3306014 to
7a7cb99
Compare
|
The PR breaks the command Steps to Reproduce:
|
|
Is there a related issue for it? please reference it with fix in PR body and commit |
`process` tasks aren't displayed in the terminal, whereas it is displayed as such in VS Code. This commit makes it so `process` tasks are displayed the same way `shell` tasks are. Signed-off-by: Paul Maréchal <paul.marechal@ericsson.com>
7a7cb99 to
35ee65d
Compare
|
@vince-fugnitto should be fixed. |
|
To people reviewing and that are familiar with VS Code tasks system: Should we rather display any task output in the terminals? Are there cases where the output is not displayed? |
there is a |
elaihau
left a comment
There was a problem hiding this comment.
I tested the change in both single and multi root workspace. I verified the followings:
- task can be started and terminated
- attach task worked
- recent tasks are displayed in the quick open properly
- detected tasks are not affected.
Thank you for the work !
@elaihau please make sure to file Theia issues to support these features |
I confirmed that it still works, thanks. |
|
Sure Anton. I created #5974 |
|
I am not sure if Theia needs |
What it does
Displays
processtask output in a terminal like VS Code.Fixes #5908.
How to test
You can use the following task configuration to see that
processtask output is now displayed in a terminal:{ "tasks": [ { "label": "[Task] Echo a string", "type": "process", "cwd": "${workspaceFolder}", "command": "bash", "args": [ "-c", "sleep 3 && echo 1 2 3" ] } ] }Review checklist
Reminder for reviewers