Skip to content

feat: esm#131

Merged
ThaUnknown merged 1 commit into
webtorrent:masterfrom
ThaUnknown:esm
Nov 28, 2022
Merged

feat: esm#131
ThaUnknown merged 1 commit into
webtorrent:masterfrom
ThaUnknown:esm

Conversation

@ThaUnknown
Copy link
Copy Markdown
Member

@ThaUnknown ThaUnknown commented Nov 14, 2022

What is the purpose of this pull request? (put an "X" next to item)

  • Documentation update
  • Bug fix
  • New feature
  • Other, please explain:

What changes did you make? (Give an overview)

  • chore: update docs and package description
  • refactor: switch to esm imports and exports

Which issue (if any) does this pull request address?

Is there anything you'd like reviewers to focus on?

@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 14, 2022

🙌 Thanks for opening this pull request! You're awesome.

@ThaUnknown ThaUnknown mentioned this pull request Nov 14, 2022
Closed
27 tasks
@ckcr4lyf
Copy link
Copy Markdown
Contributor

ckcr4lyf commented Nov 15, 2022 •
edited
Loading

Nice one, I had ended up making my own fork because I needed ESM support.

Would you consider adding a types file for Typescript? I think one of the biggest problems is the current types never worked for me in Typescript.

This is my types file: https://github.com/ckcr4lyf/bencode-esm/blob/6b9256a519753252bce44ac568b5adbc255c919c/lib/index.d.ts , to import as a named default https://github.com/ckcr4lyf/qbit-race/blob/2e56bda3372ed022effcb1114fab24f74304c926/src/helpers/torrent.ts#L1

@ThaUnknown
Copy link
Copy Markdown
Member Author

ThaUnknown commented Nov 15, 2022

no, this is ESM, make you own PR

@ThaUnknown ThaUnknown enabled auto-merge (squash) November 25, 2022 02:01
@ThaUnknown
Copy link
Copy Markdown
Member Author

ThaUnknown commented Nov 28, 2022

force pushed because Semantic Pull Request is trolling

@ThaUnknown ThaUnknown merged commit b111818 into webtorrent:master Nov 28, 2022
@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 28, 2022

🎉 Congrats on getting your first pull request landed!

webtorrent-bot pushed a commit that referenced this pull request Nov 28, 2022
@semantic-release-bot
chore(release): 3.0.0
ea5efa3 
# [3.0.0](v2.0.3...v3.0.0) (2022-11-28)

### Features

* esm ([#131](#131)) ([b111818](b111818))

### BREAKING CHANGES

* ESM only
@webtorrent-bot
Copy link
Copy Markdown

webtorrent-bot commented Nov 28, 2022

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoRBaquero DiegoRBaquero DiegoRBaquero approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ThaUnknown @ckcr4lyf @webtorrent-bot @DiegoRBaquero